From 88b314457791c85e530655d19458536c2eef5a30 Mon Sep 17 00:00:00 2001 From: John Lubinski Date: Mon, 8 Dec 2025 08:09:09 -0600 Subject: [PATCH 1/4] Make daemonset mountPropagation configurable, remove bidirectional default Signed-off-by: John Lubinski --- charts/core-dump-handler/README.md | 1 + .../core-dump-handler/templates/_helpers.tpl | 18 ++++++++++++++++++ charts/core-dump-handler/values.yaml | 1 + 3 files changed, 20 insertions(+) diff --git a/charts/core-dump-handler/README.md b/charts/core-dump-handler/README.md index 026be63..afc2446 100644 --- a/charts/core-dump-handler/README.md +++ b/charts/core-dump-handler/README.md @@ -334,6 +334,7 @@ Daemonset * envFrom: Array of [EnvFromSource](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.25/#envfromsource-v1-core) to inject into main container. * sidecarContainers: Array of [Container](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.25/#container-v1-core) to define as part of the pod. * updateStrategy: [DaemonsetUpdateStrategy](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.25/#daemonsetupdatestrategy-v1-apps) is a struct used to control the update strategy for the DaemonSet. +* mountPropagation: [Mount propagation](https://kubernetes.io/docs/concepts/storage/volumes/#mount-propagation) mode for core dump volumes. (Default "") Service account: * useToken: automatically create a service account token secret diff --git a/charts/core-dump-handler/templates/_helpers.tpl b/charts/core-dump-handler/templates/_helpers.tpl index 200465f..77ebda7 100644 --- a/charts/core-dump-handler/templates/_helpers.tpl +++ b/charts/core-dump-handler/templates/_helpers.tpl @@ -86,6 +86,24 @@ Basically copied from https://github.com/bitnami/charts/blob/master/bitnami/comm mountPath: {{ .Values.daemonset.eventDirectory }} mountPropagation: Bidirectional {{- end }} +{{- define "core-dump-handler.daemonset.container.volumeMounts" -}} +- name: host-volume + mountPath: {{ .Values.daemonset.hostDirectory }} + {{- if .Values.daemonset.mountPropagation }} + mountPropagation: {{ .Values.daemonset.mountPropagation }} + {{- end }} +- name: core-volume + mountPath: {{ .Values.daemonset.coreDirectory }} + {{- if .Values.daemonset.mountPropagation }} + mountPropagation: {{ .Values.daemonset.mountPropagation }} + {{- end }} +{{- if .Values.composer.coreEvents }} +- name: event-volume + mountPath: {{ .Values.daemonset.eventDirectory }} + {{- if .Values.daemonset.mountPropagation }} + mountPropagation: {{ .Values.daemonset.mountPropagation }} + {{- end }} +{{- end }} {{- if .Values.daemonset.mountContainerRuntimeEndpoint }} - mountPath: {{ .Values.daemonset.hostContainerRuntimeEndpoint }} name: container-runtime diff --git a/charts/core-dump-handler/values.yaml b/charts/core-dump-handler/values.yaml index 05f8213..8a4261f 100644 --- a/charts/core-dump-handler/values.yaml +++ b/charts/core-dump-handler/values.yaml @@ -60,6 +60,7 @@ daemonset: envFrom: [] sidecarContainers: [] updateStrategy: {} + mountPropagation: "" serviceAccount: create: true From 9811c301189116eef2352c95284cb11b65daa25e Mon Sep 17 00:00:00 2001 From: John Lubinski Date: Tue, 6 Jan 2026 08:43:24 -0600 Subject: [PATCH 2/4] Fix duplicated definition Signed-off-by: John Lubinski --- charts/core-dump-handler/templates/_helpers.tpl | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/charts/core-dump-handler/templates/_helpers.tpl b/charts/core-dump-handler/templates/_helpers.tpl index 77ebda7..20ea433 100644 --- a/charts/core-dump-handler/templates/_helpers.tpl +++ b/charts/core-dump-handler/templates/_helpers.tpl @@ -74,18 +74,6 @@ Basically copied from https://github.com/bitnami/charts/blob/master/bitnami/comm {{- end }} {{- end -}} -{{- define "core-dump-handler.daemonset.container.volumeMounts" -}} -- name: host-volume - mountPath: {{ .Values.daemonset.hostDirectory }} - mountPropagation: Bidirectional -- name: core-volume - mountPath: {{ .Values.daemonset.coreDirectory }} - mountPropagation: Bidirectional -{{- if .Values.composer.coreEvents }} -- name: event-volume - mountPath: {{ .Values.daemonset.eventDirectory }} - mountPropagation: Bidirectional -{{- end }} {{- define "core-dump-handler.daemonset.container.volumeMounts" -}} - name: host-volume mountPath: {{ .Values.daemonset.hostDirectory }} @@ -98,6 +86,11 @@ Basically copied from https://github.com/bitnami/charts/blob/master/bitnami/comm mountPropagation: {{ .Values.daemonset.mountPropagation }} {{- end }} {{- if .Values.composer.coreEvents }} +- name: event-volume + mountPath: {{ .Values.daemonset.eventDirectory }} + mountPropagation: Bidirectional +{{- end }} +{{- if .Values.composer.coreEvents }} - name: event-volume mountPath: {{ .Values.daemonset.eventDirectory }} {{- if .Values.daemonset.mountPropagation }} From 6f5ffe73bae4a6e9ea537abee93e480b48671d2e Mon Sep 17 00:00:00 2001 From: John Lubinski Date: Fri, 16 Jan 2026 08:44:41 -0600 Subject: [PATCH 3/4] Retrigger tests Signed-off-by: John Lubinski From fdf65b6c85a47976a9fd10ba3753735210a096c6 Mon Sep 17 00:00:00 2001 From: John Lubinski Date: Fri, 16 Jan 2026 09:06:44 -0600 Subject: [PATCH 4/4] Update lint-test versions Signed-off-by: John Lubinski --- .github/workflows/lint-test.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint-test.yaml b/.github/workflows/lint-test.yaml index b0e8e7e..bb96e1e 100644 --- a/.github/workflows/lint-test.yaml +++ b/.github/workflows/lint-test.yaml @@ -19,9 +19,9 @@ jobs: # Python is required because `ct lint` runs Yamale (https://github.com/23andMe/Yamale) and # yamllint (https://github.com/adrienverge/yamllint) which require Python - name: Set up Python - uses: actions/setup-python@v2 + uses: actions/setup-python@v6.1.0 with: - python-version: 3.7 + python-version: 3.13 - name: Set up chart-testing uses: helm/chart-testing-action@v2.1.0