Skip to content

Commit 7e6c5c1

Browse files
authored
Merge pull request #127 from Hypercart-Dev-Tools/development
Development into Main
2 parents 34e4ac1 + 7fb63cf commit 7e6c5c1

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ All notable changes to this project will be documented in this file.
1818

1919
### Fixed
2020

21+
- Fixed bash `local: can only be used in a function` errors that appeared on every scan invocation. The simple-pattern runner loop uses `local` in top-level scope; replaced with plain variable assignments
22+
2123
- N+1 pattern findings now include the actual source code line in the report. Previously the `code` field was empty because `find_meta_in_loop_line` only returned the line number without extracting the source text
2224

2325
### Tests

dist/bin/check-performance.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6054,10 +6054,10 @@ if [ -n "$SIMPLE_PATTERNS" ]; then
60546054
include_args="--include=*.php"
60556055
fi
60566056
6057-
local exclude_file_globs=""
6058-
local exclude_line_patterns=""
6059-
local exclude_file_contains=""
6060-
local current_exclusion_block=""
6057+
exclude_file_globs=""
6058+
exclude_line_patterns=""
6059+
exclude_file_contains=""
6060+
current_exclusion_block=""
60616061
60626062
while IFS= read -r json_line; do
60636063
case "$json_line" in

0 commit comments

Comments
 (0)