New node: 'Attach Markers'#4172
Open
jsjgdh wants to merge 1 commit into
Open
Conversation
Contributor
Author
Contributor
|
@jsjgdh I have started the AI code review. It will take a few minutes to complete. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an "Attach Markers" node to place marker artwork at the start, middle, and end vertices of a path following SVG marker placement semantics. It adds helper functions and structures to compute tangents and transform markers. The reviewer suggested using the idiomatic .to_radians() method instead of manual conversion for the angle offset.
jsjgdh
force-pushed
the
svg-marker-node
branch
2 times, most recently
from
725ba9e to
f307f18
Compare
jsjgdh
force-pushed
the
svg-marker-node
branch
2 times, most recently
from
e15b572 to
70c6796
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 1 file
Confidence score: 3/5
- There is a concrete functional risk in
node-graph/nodes/vector/src/vector_nodes.rs: flattening vertices across subpaths drops intermediate subpath boundaries, which can misclassify start/end vertices and produce incorrect marker behavior. - Given the high severity/confidence on boundary handling (8/10, 10/10), this is more than a housekeeping concern and introduces real regression risk if merged as-is.
- The PR-title formatting issue in
node-graph/nodes/vector/src/vector_nodes.rscontext is process-only (5/10) and easy to fix, but it does not materially change runtime behavior. - Pay close attention to
node-graph/nodes/vector/src/vector_nodes.rs- subpath boundary handling needs validation so intermediate subpaths keep correct start/end classification.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP