Skip to content

security-command-center: samples contain many Spotbugs errors #9546

Description

@hegemonic

In which file did you encounter the issue?

https://github.com/GoogleCloudPlatform/java-docs-samples/tree/main/security-command-center/snippets

Did you change the file? If so, how?

no

Describe the issue

SAMPLE_FORMAT.md says the following:

To run the Checkstyle, ErrorProne and SpotBugs plugins on an existing sample, run

mvn clean verify -DskipTests -P lint

However, when I run that command in the security-command-center/snippets directory, it fails with 67 "bugs" (errors, really). I expected everything to pass at HEAD.

I didn't check any other directories, so this issue might exist elsewhere.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.samplesIssues that are directly related to samples.triage meI really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions