Skip to content

Commit 64f82c0

Browse files
authored
Merge pull request #20 from Geode-solutions/fix/file_system
fix(FileSystem): remove input_file & additional_files persistance in …
2 parents c874501 + 3ee67b2 commit 64f82c0

2 files changed

Lines changed: 17 additions & 22 deletions

File tree

src/opengeodeweb_microservice/database/data.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,28 +14,20 @@ class Data(Base):
1414
geode_object: Mapped[str] = mapped_column(String, nullable=False)
1515
viewer_object: Mapped[str] = mapped_column(String, nullable=False)
1616
viewer_elements_type: Mapped[str] = mapped_column(String, nullable=False)
17-
1817
native_file: Mapped[str | None] = mapped_column(String, nullable=True)
1918
viewable_file: Mapped[str | None] = mapped_column(String, nullable=True)
20-
2119
light_viewable_file: Mapped[str | None] = mapped_column(String, nullable=True)
22-
input_file: Mapped[str | None] = mapped_column(String, nullable=True)
23-
additional_files: Mapped[list[str] | None] = mapped_column(JSON, nullable=True)
2420

2521
@staticmethod
2622
def create(
2723
geode_object: str,
2824
viewer_object: str,
2925
viewer_elements_type: str,
30-
input_file: str | None = None,
31-
additional_files: list[str] | None = None,
3226
) -> "Data":
3327
data_entry = Data(
3428
geode_object=geode_object,
3529
viewer_object=viewer_object,
3630
viewer_elements_type=viewer_elements_type,
37-
input_file=input_file,
38-
additional_files=additional_files,
3931
)
4032

4133
session = get_session()

tests/test_database.py

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
from opengeodeweb_microservice.database.data import Data
2+
from opengeodeweb_microservice.database.connection import get_session
23

34

45
def test_data_crud_operations(clean_database: None) -> None:
56
data = Data.create(
67
geode_object="test_object",
78
viewer_object="test_viewer",
89
viewer_elements_type="test_type",
9-
input_file="test.txt",
10-
additional_files=[],
1110
)
1211
print("id", data.id, flush=True)
1312
assert data.id is not None
@@ -17,25 +16,29 @@ def test_data_crud_operations(clean_database: None) -> None:
1716
assert retrieved is not None
1817
assert isinstance(retrieved, Data)
1918
assert retrieved.geode_object == "test_object"
20-
assert retrieved.input_file == "test.txt"
2119
assert retrieved.id == data.id
2220
non_existent = Data.get("fake_id")
2321
assert non_existent is None
2422

2523

26-
def test_data_with_additional_files(clean_database: None) -> None:
27-
files = ["file1.txt", "file2.txt"]
24+
def test_data_with_file_assignments(clean_database: None) -> None:
2825
data = Data.create(
29-
geode_object="test_files",
30-
viewer_object="test_viewer",
26+
geode_object="geode_object",
27+
viewer_object="viewer_object",
3128
viewer_elements_type="test_type",
32-
additional_files=files,
3329
)
34-
assert data.id is not None
35-
assert isinstance(data.id, str)
30+
data_id = data.id
31+
data.native_file = "native.og_brep"
32+
data.viewable_file = "viewable.vtm"
33+
data.light_viewable_file = "light.vtp"
3634

37-
retrieved = Data.get(data.id)
35+
with get_session() as session:
36+
session.add(data)
37+
session.commit()
38+
39+
retrieved = Data.get(data_id)
3840
assert retrieved is not None
39-
assert isinstance(retrieved, Data)
40-
assert retrieved.additional_files == files
41-
assert retrieved.geode_object == "test_files"
41+
assert retrieved.native_file == "native.og_brep"
42+
assert retrieved.viewable_file == "viewable.vtm"
43+
assert retrieved.light_viewable_file == "light.vtp"
44+
assert retrieved.geode_object == "geode_object"

0 commit comments

Comments
 (0)