682 non-merge commits. I skipped bug fixes, as the skill says. I also skipped the reshapes that already happened: the "Simplify … (second pass)" commits, "Streamline …", and "shrink visibility impl". The candidates below come from the feature diffs and from what is in dev today. I verified each one exists before listing it here. Order: highest payoff and lowest risk first.
- Source: 34fcc38b5 (probe GI), e8d8c09f2 (surfel GI), d64591831 (lightmaps), 54f721ec8 (SSGI and contact shadows left out of the bake).
- Smell:
VisibilityFeatures(rendering/pipelines/visibility/features.rs:90) carriesssgi,surfel_gi,probe_gi, andbaked_gias separate bools. On top of those sit*_ENABLED_PARAMETERconstants and agi.techniqueselector that has to agree with them. Theindirect_diffuseumbrella rule exists only to re-derive "any GI is built in". Each technique added one more bool, one more parameter, and one more branch. - Native shape: a single built-in GI set, for example a small bitset keyed by the
gi.techniquenames thatgi.techniquealready parses. That keeps it an open set of names, not a new enum.indirect_diffusebecomes!set.is_empty(). The four*_ENABLED_PARAMETERconstants collapse into onegi.techniqueslist parameter. - Also:
built_in_or_off(manager.rs:695) is applied by hand to each feature. Make it the one place where runtime settings meet the built-in set, driven by the set. - Tests: rewrite the feature-parsing tests to the list parameter. Delete the tests that check each bool separately.
- Docs: update the reference spec first (
docs/reference, the render parameters), then the code.
- Source: ba568d549.
- Smell: the application holds
unattended: Option<Duration>(application/graphics/mod.rs:98). The renderer holds a secondunattended: bool(renderer/core.rs:111) set throughset_unattended, andif !self.unattendedchecks are scattered through window visibility and the present mode. The pacing memory says the renderer only reports state, and pacing lives in the application loop. - Native shape: the application loop owns a
Pacingvalue, either attended (max-frame-rate, render-on-demand) or fixed period. It passes the renderer what it needs per frame (which windows to render, and the present mode), not a mode flag. Deleteset_unattended.
- Source: 1e5c9aefd.
- Smell: a
_with_variant next to the original. Check whether plainexecuteisexecute_with_callerwith a no-op caller. If it is, keep one function. This touches a hot path: run the alley benches before and after, using the interleaved A/B method.
- Source: 2c57f21eb.
- Smell:
simple_tile.rs:233 record_with_constantsits besiderecord, and afusion_enabled: boolgates fusion. An unfused pass is a fusion run of length 1. If.fusionassets are the mechanism, the unfused path should be that degenerate case, not a separate one. Keep a constant-lessrecordonly if a caller really has no constant.
- Source: 53003a320.
- Smell:
resources/material.rs:196,205,679,688repeatsdynamicacross the description and baked types, plus astalebool in the renderer. Check whether "dynamic" can come from the BEMX graph, where a parameter node is either constant or exposed (104cfa9d4 made every material a graph). If it can, the flag duplicates what the graph already encodes.
- Source: 9da2bac35 (port), 368245dcf (address), c7cfa255d (streamline).
- Smell: two parameters added one after the other. Merge them into one
inspector.addresssocket address with a loopback default. Small change.
- Source: 5916c2a87.
- Check:
debug_viewsis also aVisibilityFeaturesbool, alongside thedebug_view_member-name convention. Fold it into the same built-in set as item 1 if that falls out naturally, and remove the scatteredcfgattributes by putting the pool behind the existing headed boundary.
- HID hotplug (c4538bb72 → 9d5ac17a0): already reshaped, with hidapi deleted.
- BELD roots, exclude, and prune (64053f535, 6258cc8e4, c46952a31): already streamlined in 1360ffea0.
- Animation routes, one-shots, and round-robin: each one extends the graph's own state and route model. Nothing bolted on is visible from the subjects alone, but item 8 below checks this.
- Physics, BETP, and the message bus: these were redesigns, not bolt-ons.
Before doing these, read the diffs of: the animation graph additions (7372df51a, fc1fdeed4, e54d7c72f, 27a2795f8), motion matching (6cdafa887, 77e79db74), bake intercepts (4fbd59089: read/write bools), and de36919cb ("bake one generated container material on its own").
One commit per item, refactor: style subjects in the repo's sentence-case convention. Each commit runs cargo nextest run --workspace, cargo test --doc --workspace, and the benches when it touches a hot path (items 1, 3, and 4 touch rendering and the alley). Cross-check Vulkan/DX12 compiles for 1 and 4. Items 1, 2, and 5 change the public API or parameters, so sketch them to you before implementing.