`if` statements inside of lambdas are broken after formatting.

[derkork]

Bug Description

The formatter removes the space between if and the following identifier in inline lambda functions, creating invalid syntax.

Input (valid GDScript):

visibility_changed.connect(func() -> void: if visible:_update())

Output (invalid GDScript):

visibility_changed.connect(func() -> void: ifvisible:_update())

How to Reproduce

test.gd.zip

# Run the formatter on test.gd
gdscript-formatter test.gd

# Check the diff - line 5 will show 'ifvisible' instead of 'if visible'

Version

gdscript-formatter 0.18.2

Expected Behavior

The space between if and visible should be preserved.

[NathanLovato]

Thanks for the report! I haven't tested but I think it's likely a parser issue, like it cannot parse this specific pattern. Have you tried writing the function on several lines already? This might be a viable workaround for the time being for this specific syntax pattern.

[derkork]

It seems to work better with a multi-line function, if I use that input code:

	visibility_changed.connect(func() -> void: 
			if visible:_update())

then the code gets formatted to:

	visibility_changed.connect(
		func() -> void:
			if visible:
				_update()
	)

[NathanLovato]

Cool, at least that's a workaround that you can use. Just so you know, we don't have access to the official GDScript parser, so we have to make a community implementation of it. And GDScript has really lots and lots of parsing cases it supports, and lots of its own little quirks and edge cases. This parser and formatter are done in such a way that if something is not supported, it will fail and try to fall back and preserve the text characters in there, but it will lose spaces and whatnot in the process.

This formatter is also meant as a temporary solution that just covers the most common code patterns out there until we get an official one, to avoid investing months of work into what could be the official formatter (at the same time GDScript grew so much without a formatter that making an official formatter now is very labor intensive).