Summary
The windows test scripts passed the PowerShell command as one quoted argument (-Command "Start-Sleep -Milliseconds 250"); depending on the shell quoting layer this can be parsed as a literal string rather than a command, producing flaky timeouts. The scripts drop the quotes so the tokens reach PowerShell directly.
Area
src/crates/services/terminal/src/exec.rs (windows test scripts only). Crate: terminal-core.
Reproduction or evidence
At 32f2427 the windows test commands still quote the -Command payload (exec.rs windows test blocks, 4 sites :1950/:1996/:2099/:2247); intermittent failures show the sleep never starting, tripping the timeout assertion. Test-only change; production code is untouched.
Environment
Windows runners (powershell quoting layer differences); baseline 32f2427. The cfg(windows) test face was exercised by real local runs on a Windows host (not a cfg-excluded false green); the ubuntu/macos faces are covered by the compile check (those branches are unchanged).
AI-assisted change. Testing: verified locally on Windows (cargo check -p terminal-core exit 0; cargo test --lib exec 37 passed, 0 failed, including the four affected tests delayed_poll / lifecycle / tty_poll / control_kill).
Summary
The windows test scripts passed the PowerShell command as one quoted argument (
-Command "Start-Sleep -Milliseconds 250"); depending on the shell quoting layer this can be parsed as a literal string rather than a command, producing flaky timeouts. The scripts drop the quotes so the tokens reach PowerShell directly.Area
src/crates/services/terminal/src/exec.rs (windows test scripts only). Crate: terminal-core.
Reproduction or evidence
At 32f2427 the windows test commands still quote the -Command payload (exec.rs windows test blocks, 4 sites :1950/:1996/:2099/:2247); intermittent failures show the sleep never starting, tripping the timeout assertion. Test-only change; production code is untouched.
Environment
Windows runners (powershell quoting layer differences); baseline 32f2427. The cfg(windows) test face was exercised by real local runs on a Windows host (not a cfg-excluded false green); the ubuntu/macos faces are covered by the compile check (those branches are unchanged).
AI-assisted change. Testing: verified locally on Windows (
cargo check -p terminal-coreexit 0;cargo test --lib exec37 passed, 0 failed, including the four affected tests delayed_poll / lifecycle / tty_poll / control_kill).