‹Addon> Mesh Study Workbench

[eng-abdalla-abbas]

🔌 𝗥𝗲𝗽𝗼𝘀𝗶𝘁𝗼𝗿𝘆

https://github.com/eng-abdalla-abbas/MeshStudy

📑 𝗡𝗼𝘁𝗲𝘀

My addon functions well and is helpful at this point. There so much room for improvement, but there are no major issues.  
It meets the "essential Qualities", but not the best-practice ones yet.  
I made sure the repository is well-configured, so hopefully there is no structural issues.  
I wanted to establish the base line, share the first well-working version, and not stress over the whole project.  

[chennes]

Hello @eng-abdalla-abbas --

• Please migrate your addon to the namespaced layout described here: https://freecad.github.io/Addon-Academy/Topics/Structuring/ This prevents your addon from creating conflicting imports when its paths/filenames match those of FreeCAD itself, or other addons.
• Your addon writes data to its own installation directory, which is not a good practice and can break git-based updates.
• You've hardcoded your addon's install path in many places, assuming it will be in a folder called MeshStudy. Depending on how we choose to put it into the catalog that may not be its actual folder name. Instead please use os.path.dirname(__file__) to determine the real location.
• Your version condition in package.xml is incorrectly formed, it should read <freecadmin>1.1.1</freecadmin>.
• There is no such Manifest tag as "fileversion" (non-breaking, but it's not clear what this is for).
• Use import PySide without any specific version -- FreeCAD will handle the fallbacks.

[eng-abdalla-abbas]

Hello @eng-abdalla-abbas --

• Please migrate your addon to the namespaced layout described here: https://freecad.github.io/Addon-Academy/Topics/Structuring/ This prevents your addon from creating conflicting imports when its paths/filenames match those of FreeCAD itself, or other addons.
• Your addon writes data to its own installation directory, which is not a good practice and can break git-based updates.
• You've hardcoded your addon's install path in many places, assuming it will be in a folder called MeshStudy. Depending on how we choose to put it into the catalog that may not be its actual folder name. Instead please use os.path.dirname(__file__) to determine the real location.
• Your version condition in package.xml is incorrectly formed, it should read <freecadmin>1.1.1</freecadmin>.
• There is no such Manifest tag as "fileversion" (non-breaking, but it's not clear what this is for).
• Use import PySide without any specific version -- FreeCAD will handle the fallbacks.

Hello, thank you for the detailed review. Here what I've done:

• I changed the structure to match the the namespaced layout.

• I've changed the hardcoded approach and used os.path.dirname(__file__) instead.

• I deleted the "fileversion" tag.

• I applied the tag <freecadmin>1.1.1</freecadmin> directly in the package.xml file.

• Lastly is the data written in the installation directory. It's only a backup file that is empty usually (it get erased after the operation ends successfully), but when the application crashes mid operation, the resultes remains until the user make a decision in the next operation. and I tried to store this temporary data in FreeCAD's user AppData directory (/v1.1/.), but access appear to be denied. If you could guide me in this issue I would be so grateful.