-
Notifications
You must be signed in to change notification settings - Fork 80
Open
Labels
bugSomething isn't workingSomething isn't workingneeds-triageNeeds looking at to decide what to doNeeds looking at to decide what to do
Description
Current Behavior
Currently, rate-limit is keyed based on request.sid (a session id), or falls back to src ip.
When accessing the API with a personal access token, request.sid isn't set, so the rate-limiting applies to the IP.
We should be keying on the token.
- when using a PAT, set
request.patto a hash(?) of the token. Maybe that's unnecessary and could just be the token - in the rate-limit keyGenerator function, fall back to that after
sid, but beforeip.
Expected Behavior
No response
Steps To Reproduce
No response
Environment
- FlowFuse version:
- Node.js version:
- npm version:
- Platform/OS:
- Browser:
Have you provided an initial effort estimate for this issue?
I have provided an initial effort estimate
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingneeds-triageNeeds looking at to decide what to doNeeds looking at to decide what to do
Type
Projects
Status
No status