From f5a7bbc93ad51ab2b44a50522b01f0cffd242573 Mon Sep 17 00:00:00 2001 From: Kim Gustyr Date: Mon, 9 Nov 2026 19:08:55 +0100 Subject: [PATCH] test(Segments): Run the segment audit log E2E test on SaaS again The E2E seed now lifts the organisation's audit log visibility limit on SaaS, so the skip is no longer needed. Drop the `isSaas` helper, which nothing else uses. --- frontend/e2e/helpers/utils.playwright.ts | 8 -------- frontend/e2e/tests/segment-test.pw.ts | 6 +----- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/frontend/e2e/helpers/utils.playwright.ts b/frontend/e2e/helpers/utils.playwright.ts index 310be38d1707..f8818aba7b2a 100644 --- a/frontend/e2e/helpers/utils.playwright.ts +++ b/frontend/e2e/helpers/utils.playwright.ts @@ -40,11 +40,3 @@ export const getFlagsmith = async function (): Promise { await initProm; return flagsmith as IFlagsmith; }; - -// Whether the API under test is a SaaS deployment, per its `/version/` endpoint. -export const isSaas = async function (): Promise { - const api = process.env.FLAGSMITH_API_URL || Project.api; - const res = await fetch(`${api.replace(/api\/v1\/$/, '')}version/`); - const version = (await res.json()) as { is_saas?: boolean }; - return !!version.is_saas; -}; diff --git a/frontend/e2e/tests/segment-test.pw.ts b/frontend/e2e/tests/segment-test.pw.ts index 71eb628762a5..cccb3555d525 100644 --- a/frontend/e2e/tests/segment-test.pw.ts +++ b/frontend/e2e/tests/segment-test.pw.ts @@ -1,5 +1,5 @@ import { test, expect } from '../test-setup'; -import { byId, log, createHelpers, visualSnapshot, getFlagsmith, isSaas } from '../helpers'; +import { byId, log, createHelpers, visualSnapshot, getFlagsmith } from '../helpers'; import { E2E_USER, PASSWORD, E2E_TEST_IDENTITY, E2E_SEGMENT_PROJECT_1, E2E_SEGMENT_PROJECT_2, E2E_SEGMENT_PROJECT_3 } from '../config' const REMOTE_CONFIG_FEATURE = 'remote_config' @@ -477,10 +477,6 @@ test('Segment test 4 - Create ANY rule type segment and verify match changes whe }) test('Segment test 5 - Audit log shows segment rule changes @enterprise', async ({ page }) => { - test.skip( - await isSaas(), - 'The E2E organisation has no audit log visibility on SaaS until the seeded subscription is deployed', - ) const { click, createSegment,