25-ITP-SEP| Data flows | Fithi-Teklom

[Fithi-Teklom]

1. https://codeyourfuture.github.io/Codewars-Progress-Checker/#Fithi-Teklom (code-wars exercises).
2. https://docs.google.com/document/d/1SJw5l5UmTXz0xNtLtsMD_eNCyVNcC9tJITPv7pZzhVM/edit? usp=sharing (study session with my partner)
3. https://docs.google.com/document/d/1aDrNTcaAPhTq32XIDSKIsurXCuZh_BaLrOeOePyL55o/edit?usp=sharing (demo presentation)
4. Manchester| 25-ITP-SEP| Fithi Teklom| Sprint 2 | Book Library CodeYourFuture/Module-Data-Flows#361 (Book library PR)
5. Manchester| Fithi Teklom| Project-Tv-Show_Mahtem | level-400 Mahtem/Project-TV-Show#6 (level-400 PR)
6. Manchester | Fithi Teklom| Project-Tv-Show| Level-500_final Project-TV-Show#8 (level-500 PR)
7. [PD] Linkedin Social Selling Index #2 (social selling index issue)
8. https://github.com/Fithi-Teklom/Project-TV-Show (git repository to my tv show project)
9. https://cyf-fithi-teklom-tv.netlify.app/ (netlify project tv url)

[illicitonion]

Hi @Fithi-Teklom - your TV show project links (both the netlify and the git repo) aren't correct. The netlify one probably goes to a list of your projects, but doesn't work for me because I'm not logged in as you. The repo link is a link to all of your repos, not to your actual single repo. Please update them and reply on this issue when you have :)

[Fithi-Teklom]

HI

Hi @Fithi-Teklom - your TV show project links (both the netlify and the git repo) aren't correct. The netlify one probably goes to a list of your projects, but doesn't work for me because I'm not logged in as you. The repo link is a link to all of your repos, not to your actual single repo. Please update them and reply on this issue when you have :)

HI illicitonion Thank you for the feedback, I believe I have fixed the issues now.

[illicitonion]

Hi Fithi! Thanks for fixing!

I'm going to approve your step (congratulations!), but here are a few things to think about in your implementation:

• It seems strange that you'd have both showShowsError and showShowsError functions (same with the show loading functions) - these feel like they could be shared?
• You have an XSS vulnerability due to your use of innerHTML with untrusted input: Have a read of https://medium.com/@sparklewebhelp/understanding-the-risks-of-using-inner-html-in-web-development-30d4fa67f815 and see if you can fix it

But everything is looking great, well done!

[Fithi-Teklom]

Hi Fithi! Thanks for fixing!

I'm going to approve your step (congratulations!), but here are a few things to think about in your implementation:

• It seems strange that you'd have both showShowsError and showShowsError functions (same with the show loading functions) - these feel like they could be shared?
• You have an XSS vulnerability due to your use of innerHTML with untrusted input: Have a read of https://medium.com/@sparklewebhelp/understanding-the-risks-of-using-inner-html-in-web-development-30d4fa67f815 and see if you can fix it

But everything is looking great, well done!

Thank you so much for your feedback,I am so grateful. And for sure I am going to fix the small issues and learn my lessons!