Commit d032edd
committed
Make ServerTraceServices.start() plugins argument optional
#68 added a `plugins` keyword-only parameter to
ServerTraceServices.start() but without a default value, making it
required. This breaks every existing caller -- including this project's
own tests/test_server.py::test_trace -- with:
TypeError: ServerTraceServices.start() missing 1 required
keyword-only argument: 'plugins'
The method body already treats the argument as optional
(`if plugins is not None:`) and its docstring documents it as FB6+ only,
so restore the `= None` default. Adds a regression test asserting the
parameter keeps a default of None.1 parent 5e3c3c8 commit d032edd
2 files changed
Lines changed: 15 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5496 | 5496 | | |
5497 | 5497 | | |
5498 | 5498 | | |
5499 | | - | |
| 5499 | + | |
5500 | 5500 | | |
5501 | 5501 | | |
5502 | 5502 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
158 | 159 | | |
159 | 160 | | |
160 | 161 | | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
161 | 175 | | |
162 | 176 | | |
163 | 177 | | |
| |||
0 commit comments