Sonar findings

Author: R-Sandor

server/src/main/java/dev/findfirst/core/dto/BookmarkDTO.java

@@ -5,6 +5,7 @@
 
 import com.fasterxml.jackson.annotation.JsonProperty;
 import lombok.AllArgsConstructor;
+import lombok.Builder;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 import lombok.Setter;
@@ -15,6 +16,7 @@
 @Setter
 @AllArgsConstructor
 @NoArgsConstructor
+@Builder
 public class BookmarkDTO {
 
   private long id;
@@ -27,9 +29,4 @@ public class BookmarkDTO {
   private List<TagOnly> tags;
   private String textHighlight;
 
-  public BookmarkDTO(long id, String title, String url, String screenshotUrl, boolean scrapable,
-      Date createdDate, Date lastModifiedOn, List<TagOnly> tags) {
-    // we don't have any highlighted text.
-    this(id, title, url, screenshotUrl, scrapable, createdDate, lastModifiedOn, tags, null);
-  }
 }

server/src/main/java/dev/findfirst/core/service/BookmarkService.java

@@ -137,8 +137,12 @@ public List<BookmarkDTO> convertBookmarkJDBCToDTO(List<BookmarkJDBC> bookmarkEnt
         tagDTOs.add(new TagOnly(t.getId(), t.getTitle()));
       }
 
-      return new BookmarkDTO(ent.getId(), ent.getTitle(), ent.getUrl(), ent.getScreenshotUrl(),
-          ent.getScrapable(), ent.getCreatedDate(), ent.getLastModifiedDate(), tagDTOs);
+      var dto = BookmarkDTO.builder().id(ent.getId()).title(ent.getTitle()).url(ent.getUrl())
+          .screenshotUrl(ent.getScreenshotUrl()).scrapable(ent.getScrapable())
+          .createdDate(ent.getCreatedDate()).lastModifiedOn(ent.getLastModifiedDate()).tags(tagDTOs)
+          .build();
+
+      return dto;
     }).toList();
   }
 
@@ -349,7 +353,8 @@ public Flux<BookmarkDTO> importBookmarks(String htmlFile) {
           | URISyntaxException ex) {
         log.error(ex.getMessage());
       }
-      return new BookmarkDTO(0, null, null, null, false, null, null, null);
+      // empty bookmark.
+      return new BookmarkDTO();
     }).delayElements(Duration.ofMillis(100));
   }
 

server/src/main/java/dev/findfirst/core/service/TypesenseService.java

@@ -27,8 +27,7 @@
 @Slf4j
 public class TypesenseService {
 
-  public record SearchHighlightResult(Long id, String highlight) {
-  };
+  public record SearchHighlightResult(Long id, String highlight) {};
 
   private final TypsenseInitializationRepository initRepo;
 
@@ -58,7 +57,8 @@ private CollectionSchema createCollectionSchemaSchema() {
 
   private String saveSchema(TypesenseInitRecord initRecord) {
     try {
-      CollectionResponse collectionResponse = client.collections().create(createCollectionSchemaSchema());
+      CollectionResponse collectionResponse =
+          client.collections().create(createCollectionSchemaSchema());
       log.debug(collectionResponse.toString());
       initRecord.setInitialized(true);
       initRepo.save(initRecord);
@@ -93,7 +93,8 @@ public List<SearchHighlightResult> search(String text) {
         .highlightFields("text").highlightStartTag("<mark>").highlightEndTag("</mark>");
     try {
       log.debug("searching");
-      SearchResult searchResult = client.collections(schemaName).documents().search(searchParameters);
+      SearchResult searchResult =
+          client.collections(schemaName).documents().search(searchParameters);
       log.debug(searchResult.toString());
 
       return searchResult.getHits().stream().map(hit -> {