Summary
Add debug-level trace output when evaluate_rules skips a rule due to an expected evaluation error (BufferOverrun, InvalidOffset, TypeReadError).
Context
In src/evaluator/engine/mod.rs, the evaluate_rules function gracefully skips individual rules that fail with expected evaluation errors (line ~200). This is correct behavior -- one rule's buffer overrun should not abort evaluation of all remaining rules.
However, when a rule is skipped, there is no diagnostic output. Users cannot distinguish between "rule didn't match the file" and "rule failed internally." This makes debugging magic file rules difficult.
Acceptance Criteria
Impact
LOW -- Developer/debugging experience improvement. No functional impact.
Files to Modify
src/evaluator/engine/mod.rs -- Add tracing::debug! or log::debug! calls at skip points
References
- TODO comment at
src/evaluator/engine/mod.rs:201
Summary
Add debug-level trace output when
evaluate_rulesskips a rule due to an expected evaluation error (BufferOverrun, InvalidOffset, TypeReadError).Context
In
src/evaluator/engine/mod.rs, theevaluate_rulesfunction gracefully skips individual rules that fail with expected evaluation errors (line ~200). This is correct behavior -- one rule's buffer overrun should not abort evaluation of all remaining rules.However, when a rule is skipped, there is no diagnostic output. Users cannot distinguish between "rule didn't match the file" and "rule failed internally." This makes debugging magic file rules difficult.
Acceptance Criteria
Impact
LOW -- Developer/debugging experience improvement. No functional impact.
Files to Modify
src/evaluator/engine/mod.rs-- Addtracing::debug!orlog::debug!calls at skip pointsReferences
src/evaluator/engine/mod.rs:201