Skip to content

Improve handling of module parameters in MOM_input #301

@alperaltuntas

Description

@alperaltuntas

Currently, in MOM_input.yaml, we place parameters that don't belong to any modules under the Global block, and module parameters under respoective module blocks. For instance:

Global:
  INPUTDIR:
      ...
  TRIPOLAR_N:
      ...

KPP:
   N_SMOOTH:
      ...
   STOKES_MOST
      ...

MLE:
    USE_BODNER23:
      ...
    CR:
      ...

Given the size of this file, it's easy to make mistakes, where a parameter may inadvertently be placed under a module it doesn't belong to.

I have two improvement suggestions.

  1. Rather than having module blocks, explicitlyspecify module names in parameter names. So the above entries would look like:
INPUTDIR:
    ...
TRIPOLAR_N:
    ...

KPP%N_SMOOTH:
    ...
KPP%STOKES_MOST
    ...

MLE%USE_BODNER23:
    ...
MLE%CR:
    ...
  1. Turn relevant warnings into failures.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions