Improvement Ideas

[grabnerandi]

#1: Extend sample to work WITHOUT having to define the Service Tagging Rule. In order for this to work enable Monspec to also define tags that work on the underlying Process Group Instance for that Service

#2: There seems to be a time lag between the first time the app process comes up until the OneAgent sends the data to Dynatrace. This results in the pushDeploymentInfo call to FAIL the first time we execute the pipeline. Add a retry to that lambda function to not fail right away

[grabnerandi]

I fixed the timing issue as described in #2. I added a retry to make sure we are not failing in case the OneAgent hasnt yet detected all meta data and automatic rules have not yet been applied. Retry count and time between retries can be adjusted in the pushDynatraceDeploymentEvent lambda

Use the configuration API to create the auto-tag rule. This will prevent the first deployment failing.

We could use Custom Resources for this:

  CustomFunction:
    Type: AWS::Lambda::Function
    Properties:
      Code:
        ZipFile: |
          import cfnresponse
          from botocore.vendored import requests
          def handler(event, context):
            if event["RequestType"] in ["Create", "Update"]:
              requests.put("https://***.live.dynatrace.com/api/config/v1/autoTags/12345678-1234-1234-1234-123456789012?Api-Token=***", {BODY-CONTENT-JSON-HERE})
            elif event["RequestType"] == "Delete":
              pass  # if you want to do something on delete, do it here
            cfnresponse.send(event, context, cfnresponse.SUCCESS, {}, "ok")
      Handler: index.handler
      Role: !GetAtt CustomFunctionRole.Arn
      Runtime: python3.6
  CustomFunctionRole:
    Properties:
      AssumeRolePolicyDocument:
        Version: '2012-10-17'
        Statement:
          - Action:
              - sts:AssumeRole
            Effect: Allow
            Principal:
              Service:
                - lambda.amazonaws.com
      ManagedPolicyArns:
        - arn:aws:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole
  Custom:
    Type: Custom::Something
    Properties:
      ServiceToken: !GetAtt CustomFunction.Arn