Support customized get_data_class target modules#139
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for customized target modules in the get_data_class function, allowing callers to search for dataset classes in additional modules beyond the default ones. However, the PR also includes unrelated changes to the preview_sensor_data method in the embodied environment.
Changes:
- Added
extra_modulesparameter toget_data_classfunction to support custom dataset module locations - Refactored module list to use
DEFAULT_DATA_MODULESconstant instead of inline list - Added
saveparameter topreview_sensor_datamethod to optionally save images instead of displaying them - Changed default visualization method from "plt" to "cv2" in
preview_sensor_data
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| embodichain/data/dataset.py | Adds extra_modules parameter to get_data_class and refactors to use DEFAULT_DATA_MODULES constant |
| embodichain/lab/gym/envs/embodied_env.py | Adds save parameter and changes default method to "cv2" in preview_sensor_data |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same as PR title
Type of change
Checklist
black .command to format the code base.