Skip to content

Support customized get_data_class target modules#139

Merged
yuecideng merged 3 commits intomainfrom
yueci/misc-update
Feb 14, 2026
Merged

Support customized get_data_class target modules#139
yuecideng merged 3 commits intomainfrom
yueci/misc-update

Conversation

@yuecideng
Copy link
Contributor

@yuecideng yuecideng commented Feb 14, 2026

Description

Same as PR title

Type of change

  • Enhancement (non-breaking change which improves an existing functionality)

Checklist

  • I have run the black . command to format the code base.
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Dependencies have been updated, if applicable.

Copilot AI review requested due to automatic review settings February 14, 2026 07:16
@yuecideng yuecideng added the data Related to data module label Feb 14, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for customized target modules in the get_data_class function, allowing callers to search for dataset classes in additional modules beyond the default ones. However, the PR also includes unrelated changes to the preview_sensor_data method in the embodied environment.

Changes:

  • Added extra_modules parameter to get_data_class function to support custom dataset module locations
  • Refactored module list to use DEFAULT_DATA_MODULES constant instead of inline list
  • Added save parameter to preview_sensor_data method to optionally save images instead of displaying them
  • Changed default visualization method from "plt" to "cv2" in preview_sensor_data

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
embodichain/data/dataset.py Adds extra_modules parameter to get_data_class and refactors to use DEFAULT_DATA_MODULES constant
embodichain/lab/gym/envs/embodied_env.py Adds save parameter and changes default method to "cv2" in preview_sensor_data

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yuecideng yuecideng merged commit 7676813 into main Feb 14, 2026
1 of 2 checks passed
@yuecideng yuecideng deleted the yueci/misc-update branch February 14, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Related to data module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments