Skip to content

Commit 87e1247

Browse files
committed
update the return value to boolean in both card-validator.js and card-validator.test.js - all tests pass
1 parent 8939f58 commit 87e1247

2 files changed

Lines changed: 15 additions & 15 deletions

File tree

Sprint-3/4-stretch/card-validator.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,15 +57,15 @@ const validateCard = (card) => {
5757
hasEvenFinalDigit &&
5858
hasSumOver15 &&
5959
hasMultipleDistinctDigits
60-
? "Valid card"
61-
: "Invalid card";
60+
? true
61+
: false;
6262
};
6363

64-
console.log(validateCard(9999777788880000)); // valid
65-
console.log(validateCard(6666666666661666)); // valid
66-
console.log(validateCard("a92332119c011112")); // Invalid
67-
console.log(validateCard(4444444444444444)); // Invalid
68-
console.log(validateCard(1111111111111110)); // Invalid
69-
console.log(validateCard(6666666666666661)); // Invalid
64+
console.log(validateCard(9999777788880000)); // true
65+
console.log(validateCard(6666666666661666)); // true
66+
console.log(validateCard("a92332119c011112")); // false
67+
console.log(validateCard(4444444444444444)); // false
68+
console.log(validateCard(1111111111111110)); // false
69+
console.log(validateCard(6666666666666661)); // false
7070

7171
module.exports = validateCard;

Sprint-3/4-stretch/card-validator.test.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,41 +3,41 @@ const validateCard = require("./card-validator");
33
test("should have 16 digits, all numbers", () => {
44
const cardNumber = 9999777788880000;
55
const result = validateCard(cardNumber);
6-
expect(result).toBe("Valid card");
6+
expect(result).toBe(true);
77
});
88

99
test("should not have less than 16 digits", () => {
1010
const cardNumber = 99997777;
1111
const result = validateCard(cardNumber);
12-
expect(result).toBe("Invalid card");
12+
expect(result).toBe(false);
1313
});
1414

1515
test("should have at least two different distinct digits", () => {
1616
const cardNumber = 9999777788880000;
1717
const result = validateCard(cardNumber);
18-
expect(result).toBe("Valid card");
18+
expect(result).toBe(true);
1919
});
2020

2121
test("should have even final digit", () => {
2222
const cardNumber = 6666666666661666;
2323
const result = validateCard(cardNumber);
24-
expect(result).toBe("Valid card");
24+
expect(result).toBe(true);
2525
});
2626

2727
test("total sum of numbers should be greater than 15", () => {
2828
const cardNumber = 6666666666661666;
2929
const result = validateCard(cardNumber);
30-
expect(result).toBe("Valid card");
30+
expect(result).toBe(true);
3131
});
3232

3333
test("single repeating digit is invalid", () => {
3434
const cardNumber = 4444444444444444;
3535
const result = validateCard(cardNumber);
36-
expect(result).toBe("Invalid card");
36+
expect(result).toBe(false);
3737
});
3838

3939
test("digits cannot include non numerals", () => {
4040
const cardNumber = "a92332119c011112";
4141
const result = validateCard(cardNumber);
42-
expect(result).toBe("Invalid card");
42+
expect(result).toBe(false);
4343
});

0 commit comments

Comments
 (0)