diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html
index 23acfa71..89cbc73e 100644
--- a/debugging/book-library/index.html
+++ b/debugging/book-library/index.html
@@ -1,12 +1,9 @@
-
-
+
+
-
-
+ My Book Library App
+
+
@@ -31,7 +28,7 @@ Library
Library
/>
Library
type="submit"
value="Submit"
class="btn btn-primary"
- onclick="submit();"
+ id="submit"
/>
@@ -91,6 +88,6 @@ Library
-
+
diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js
index 75ce6c1d..c9c21d51 100644
--- a/debugging/book-library/script.js
+++ b/debugging/book-library/script.js
@@ -1,46 +1,56 @@
-let myLibrary = [];
+const myLibrary = [];
+const titleInput = document.getElementById("title");
+const authorInput = document.getElementById("author");
+const pagesInput = document.getElementById("pages");
+const checkInput = document.getElementById("check");
window.addEventListener("load", function (e) {
populateStorage();
render();
+ document.getElementById("submit").addEventListener("click", submit);
});
function populateStorage() {
if (myLibrary.length == 0) {
- let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
- let book2 = new Book(
+ const book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true);
+ const book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
- "127",
+ 127,
true
);
myLibrary.push(book1);
myLibrary.push(book2);
- render();
}
}
-const title = document.getElementById("title");
-const author = document.getElementById("author");
-const pages = document.getElementById("pages");
-const check = document.getElementById("check");
-
//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
- if (
- title.value == null ||
- title.value == "" ||
- pages.value == null ||
- pages.value == ""
- ) {
- alert("Please fill all fields!");
+ const trimmedTitle = titleInput.value.trim();
+ const trimmedAuthor = authorInput.value.trim();
+ const pagesInt = parseInt(pagesInput.value, 10);
+ if (trimmedTitle === "") {
+ alert("Please enter a title.");
+ return false;
+ }
+ if (trimmedAuthor === "") {
+ alert("Please enter an author.");
return false;
- } else {
- let book = new Book(title.value, title.value, pages.value, check.checked);
- library.push(book);
- render();
}
+ if (isNaN(pagesInt) || pagesInt <= 0) {
+ alert("Please enter a valid number of pages");
+ return false;
+ }
+
+ const book = new Book(
+ trimmedTitle,
+ trimmedAuthor,
+ pagesInt,
+ checkInput.checked
+ );
+ myLibrary.push(book);
+ render();
}
function Book(title, author, pages, check) {
@@ -51,37 +61,28 @@ function Book(title, author, pages, check) {
}
function render() {
- let table = document.getElementById("display");
- let rowsNumber = table.rows.length;
- //delete old table
- for (let n = rowsNumber - 1; n > 0; n-- {
- table.deleteRow(n);
- }
+ const table = document.getElementById("display");
+ const tbody = table.tBodies[0];
+ tbody.innerHTML = "";
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
- let row = table.insertRow(1);
- let titleCell = row.insertCell(0);
- let authorCell = row.insertCell(1);
- let pagesCell = row.insertCell(2);
- let wasReadCell = row.insertCell(3);
- let deleteCell = row.insertCell(4);
- titleCell.innerHTML = myLibrary[i].title;
- authorCell.innerHTML = myLibrary[i].author;
- pagesCell.innerHTML = myLibrary[i].pages;
+ const row = tbody.insertRow(-1);
+ const titleCell = row.insertCell(0);
+ const authorCell = row.insertCell(1);
+ const pagesCell = row.insertCell(2);
+ const wasReadCell = row.insertCell(3);
+ const deleteCell = row.insertCell(4);
+ titleCell.textContent = myLibrary[i].title;
+ authorCell.textContent = myLibrary[i].author;
+ pagesCell.textContent = myLibrary[i].pages;
//add and wait for action for read/unread button
- let changeBut = document.createElement("button");
- changeBut.id = i;
+ const changeBut = document.createElement("button");
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
- let readStatus = "";
- if (myLibrary[i].check == false) {
- readStatus = "Yes";
- } else {
- readStatus = "No";
- }
- changeBut.innerText = readStatus;
+
+ changeBut.innerText = myLibrary[i].check ? "Yes" : "No";
changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
@@ -89,14 +90,13 @@ function render() {
});
//add delete button to every row and render again
- let delButton = document.createElement("button");
- delBut.id = i + 5;
+ const delBut = document.createElement("button");
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
- delBut.addEventListener("clicks", function () {
- alert(`You've deleted title: ${myLibrary[i].title}`);
+ delBut.addEventListener("click", function () {
myLibrary.splice(i, 1);
+ alert(`You've deleted title: ${myLibrary[i].title}`);
render();
});
}