From 7f3ad9ab181ddd2271befde95bdd280a96ac04dd Mon Sep 17 00:00:00 2001 From: CJ Yuan Date: Tue, 20 May 2025 10:20:30 +0100 Subject: [PATCH 1/6] Added "No review required" note and PR template (#693) --- .github/pull_request_template.md | 35 ++++++++++++++++++++++++++++++++ PHAIK_SOON.md | 5 +++++ README.md | 7 ++++--- 3 files changed, 44 insertions(+), 3 deletions(-) create mode 100644 .github/pull_request_template.md create mode 100644 PHAIK_SOON.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..c3e0510b --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,35 @@ + + +## Learners, PR Template + + +Self checklist + +- [ ] I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME +- [ ] My changes meet the requirements outlined in the `README.md` of this task + +## Changelist + + +Briefly explain your PR. diff --git a/PHAIK_SOON.md b/PHAIK_SOON.md new file mode 100644 index 00000000..582d1a79 --- /dev/null +++ b/PHAIK_SOON.md @@ -0,0 +1,5 @@ +Phaik Soon +My favorite sport is Pole dancing. It makes me feel alive and align to who I am from within. +My favorite food is Hot Pot with Pork Soup Base. It reminds me family reunion, the precious time we spend together - the moment pull out from a chaotic and unpredictable environment. +https://www.youtube.com/watch?v=kkboMZDkT-s&list=RDkkboMZDkT-s&start_radio=1 +I enjoy watching my toy poodle eating her food peacefully! \ No newline at end of file diff --git a/README.md b/README.md index 729cb32f..f6a309ea 100644 --- a/README.md +++ b/README.md @@ -26,11 +26,12 @@ To learn more about **pull requests** and how to create one, please use this gui 9. Open a `Pull Request` to this repository -## Finished Work +## How to check your work? +If you have correctly submitted your PR, you can find it in https://github.com/CodeYourFuture/GitHomeworkTest/pulls. -When you've finished you should have a `pull request` that looks like this +Your PR should look like this: https://github.com/CodeYourFuture/GitHomeworkTest/pull/692 -https://github.com/CodeYourFuture/GitHomeworkTest/pull/1 +**Please note that your PR will not undergo an official review, as none is required.** Most PRs at CodeYourFuture get reviewed, but this one is just for you to practice creating them. ## Asking for Help From d675f33d679455a8e9e096a2943e8d8e06b05af9 Mon Sep 17 00:00:00 2001 From: CJ Yuan Date: Tue, 20 May 2025 10:20:30 +0100 Subject: [PATCH 2/6] Add HTML form for T-shirt information and create results page --- .github/pull_request_template.md | 35 +++++++++++++++++++++++ PHAIK_SOON.md | 8 ++++++ README.md | 7 +++-- index.html | 49 ++++++++++++++++++++++++++++++++ results.html | 0 5 files changed, 96 insertions(+), 3 deletions(-) create mode 100644 .github/pull_request_template.md create mode 100644 PHAIK_SOON.md create mode 100644 index.html create mode 100644 results.html diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..c3e0510b --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,35 @@ + + +## Learners, PR Template + + +Self checklist + +- [ ] I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME +- [ ] My changes meet the requirements outlined in the `README.md` of this task + +## Changelist + + +Briefly explain your PR. diff --git a/PHAIK_SOON.md b/PHAIK_SOON.md new file mode 100644 index 00000000..15fbdb59 --- /dev/null +++ b/PHAIK_SOON.md @@ -0,0 +1,8 @@ + +
Phaik Soon
+ + +
My favorite sport is Pole dancing. It makes me feel alive and align to who I am from within.
+
My favorite food is Hot Pot with Pork Soup Base. It reminds me family reunion, the precious time we spend together - the moment pull out from a chaotic and unpredictable environment.
+[!Watch the video](https://www.youtube.com/watch?v=kkboMZDkT-s&list=RDkkboMZDkT-s&start_radio=1) +
I enjoy watching my toy poodle eating her food peacefully!
\ No newline at end of file diff --git a/README.md b/README.md index 729cb32f..f6a309ea 100644 --- a/README.md +++ b/README.md @@ -26,11 +26,12 @@ To learn more about **pull requests** and how to create one, please use this gui 9. Open a `Pull Request` to this repository -## Finished Work +## How to check your work? +If you have correctly submitted your PR, you can find it in https://github.com/CodeYourFuture/GitHomeworkTest/pulls. -When you've finished you should have a `pull request` that looks like this +Your PR should look like this: https://github.com/CodeYourFuture/GitHomeworkTest/pull/692 -https://github.com/CodeYourFuture/GitHomeworkTest/pull/1 +**Please note that your PR will not undergo an official review, as none is required.** Most PRs at CodeYourFuture get reviewed, but this one is just for you to practice creating them. ## Asking for Help diff --git a/index.html b/index.html new file mode 100644 index 00000000..28d198ec --- /dev/null +++ b/index.html @@ -0,0 +1,49 @@ + + + + + + Form + + +
+
+

+ Your T-Shirt Information +

+ + + +
+
+ + +
+ Pick your favourite T-shirt colour: +
+ + + + + + +
+
+ + +
+
+ + +
+ +
+ + \ No newline at end of file diff --git a/results.html b/results.html new file mode 100644 index 00000000..e69de29b From 5691c07a2b6d6f6a4a4b2c5cf954ce4b0b52726d Mon Sep 17 00:00:00 2001 From: Phaik Soon Date: Fri, 15 May 2026 19:55:42 +0100 Subject: [PATCH 3/6] spelling update --- index.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/index.html b/index.html index 28d198ec..92a62545 100644 --- a/index.html +++ b/index.html @@ -19,7 +19,7 @@

- Pick your favourite T-shirt colour: + Pick your favorite T-shirt color:
@@ -29,7 +29,7 @@

- +
From ff9f8ca467cc996b10a8f40d33e67c2f6ce9dc1d Mon Sep 17 00:00:00 2001 From: Phaik Date: Fri, 15 May 2026 20:09:52 +0100 Subject: [PATCH 4/6] Clean up PHAIK_SOON.md by removing duplicates Removed video link and duplicated content. --- PHAIK_SOON.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/PHAIK_SOON.md b/PHAIK_SOON.md index 0216a80d..f490209a 100644 --- a/PHAIK_SOON.md +++ b/PHAIK_SOON.md @@ -4,9 +4,8 @@
My favorite sport is Pole dancing. It makes me feel alive and align to who I am from within.
My favorite food is Hot Pot with Pork Soup Base. It reminds me family reunion, the precious time we spend together - the moment pull out from a chaotic and unpredictable environment.
-[!Watch the video](https://www.youtube.com/watch?v=kkboMZDkT-s&list=RDkkboMZDkT-s&start_radio=1)
I enjoy watching my toy poodle eating her food peacefully!
Phaik Soon My favorite sport is Pole dancing. It makes me feel alive and align to who I am from within. My favorite food is Hot Pot with Pork Soup Base. It reminds me family reunion, the precious time we spend together - the moment pull out from a chaotic and unpredictable environment. https://www.youtube.com/watch?v=kkboMZDkT-s&list=RDkkboMZDkT-s&start_radio=1 -I enjoy watching my toy poodle eating her food peacefully! \ No newline at end of file +I enjoy watching my toy poodle eating her food peacefully! From d8294bfb1bb0052e4e0874d69db020ce5139c454 Mon Sep 17 00:00:00 2001 From: Phaik Date: Fri, 15 May 2026 20:10:28 +0100 Subject: [PATCH 5/6] Clean up PHAIK_SOON.md content Removed duplicate lines and fixed formatting. --- PHAIK_SOON.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/PHAIK_SOON.md b/PHAIK_SOON.md index f490209a..6b5b7be6 100644 --- a/PHAIK_SOON.md +++ b/PHAIK_SOON.md @@ -4,8 +4,5 @@
My favorite sport is Pole dancing. It makes me feel alive and align to who I am from within.
My favorite food is Hot Pot with Pork Soup Base. It reminds me family reunion, the precious time we spend together - the moment pull out from a chaotic and unpredictable environment.
-
I enjoy watching my toy poodle eating her food peacefully!
Phaik Soon -My favorite sport is Pole dancing. It makes me feel alive and align to who I am from within. -My favorite food is Hot Pot with Pork Soup Base. It reminds me family reunion, the precious time we spend together - the moment pull out from a chaotic and unpredictable environment. https://www.youtube.com/watch?v=kkboMZDkT-s&list=RDkkboMZDkT-s&start_radio=1 I enjoy watching my toy poodle eating her food peacefully! From 01756e27658b2a08e739104eff28bf2bccb5ddf1 Mon Sep 17 00:00:00 2001 From: Phaik Date: Fri, 15 May 2026 20:11:03 +0100 Subject: [PATCH 6/6] Format favorite activity description in div tags --- PHAIK_SOON.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PHAIK_SOON.md b/PHAIK_SOON.md index 6b5b7be6..9330f00a 100644 --- a/PHAIK_SOON.md +++ b/PHAIK_SOON.md @@ -5,4 +5,4 @@
My favorite sport is Pole dancing. It makes me feel alive and align to who I am from within.
My favorite food is Hot Pot with Pork Soup Base. It reminds me family reunion, the precious time we spend together - the moment pull out from a chaotic and unpredictable environment.
https://www.youtube.com/watch?v=kkboMZDkT-s&list=RDkkboMZDkT-s&start_radio=1 -I enjoy watching my toy poodle eating her food peacefully! +
I enjoy watching my toy poodle eating her food peacefully!