The github-oauth callback's 'create-fresh' outcome writes a new `Person` + `PrivateProfile` and mints a session, but does not send a welcome notification.
Per the github-oauth plan: 'A 'fresh user' creation might want to send a welcome notification. Defer if unclear; this plan's notifier deferral should land alongside the existing write-api one.'
The existing `Notifier` interface in `apps/api/src/notify/index.ts` only declares `notifyHelpWantedInterest` and `notifyHelpWantedFilled`. A future notifier shake-up could:
- add `notifyAccountWelcome(personId, slug, fullName, email)` to the interface
- call it from `completeCallback` after `mintSessionFor` returns for the `create-fresh` branch
- the `LoggingNotifier` stub logs; a real notifier (Resend) sends an email
Out of scope for github-oauth; tracked here.
The github-oauth callback's 'create-fresh' outcome writes a new `Person` + `PrivateProfile` and mints a session, but does not send a welcome notification.
Per the github-oauth plan: 'A 'fresh user' creation might want to send a welcome notification. Defer if unclear; this plan's notifier deferral should land alongside the existing write-api one.'
The existing `Notifier` interface in `apps/api/src/notify/index.ts` only declares `notifyHelpWantedInterest` and `notifyHelpWantedFilled`. A future notifier shake-up could:
Out of scope for github-oauth; tracked here.