Skip to content

Commit fabe818

Browse files
authored
Merge pull request #9 from Boyeep/chore/remove-dependency-review
Remove dependency review workflow
2 parents 8456b61 + b3ed02c commit fabe818

5 files changed

Lines changed: 7 additions & 45 deletions

File tree

.github/dependency-review-config.yml

Lines changed: 0 additions & 7 deletions
This file was deleted.

.github/workflows/dependency-review.yml

Lines changed: 0 additions & 20 deletions
This file was deleted.

CONTRIBUTING.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,6 @@ npm run report:licenses
9595

9696
That command writes generated reports into `reports/licenses/`.
9797

98-
Dependency review also runs automatically on pull requests to catch newly introduced vulnerable dependency changes.
99-
100-
That dependency review config also includes an allowlist for the licenses already present in the current dependency tree. If you intentionally add a dependency under a new acceptable license, update `.github/dependency-review-config.yml` in the same pull request.
101-
10298
## Changing the API Contract
10399

104100
If you modify request or response shapes:

README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,12 +123,8 @@ The root check runs:
123123

124124
CodeQL code scanning also runs on GitHub for `javascript-typescript`, `python`, and workflow files.
125125

126-
Pull requests also run GitHub dependency review so new vulnerable dependency changes are easier to catch before merge.
127-
128126
A separate GitHub workflow generates license-report artifacts for the root workspace, frontend workspace, and backend Python environment.
129127

130-
The dependency-review config also keeps a conservative allowlist of licenses already present in the current dependency tree, so tightening policy does not start by breaking routine updates.
131-
132128
An SBOM workflow also publishes SPDX artifacts for the repository source plus the frontend and backend runner images.
133129

134130
## Releases

template-playbook.md

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ Build the second layer early, not after the repo gets messy.
6868

6969
- workflow lint
7070
- secret scan
71-
- dependency review on pull requests
71+
- optional dependency review on pull requests if it stays low-noise for the repo
7272
- license reporting when dependency visibility matters
7373
- SBOM generation for source or publishable artifacts when relevant
7474
- app verification
@@ -292,8 +292,6 @@ Keep:
292292
- `scripts/report-licenses.mjs`
293293
- `.github/workflows/template-ci.yml`
294294
- `.github/workflows/codeql.yml`
295-
- `.github/workflows/dependency-review.yml`
296-
- `.github/dependency-review-config.yml`
297295
- `.github/workflows/license-report.yml`
298296
- `.github/workflows/sbom.yml`
299297
- `SECURITY.md`
@@ -302,7 +300,7 @@ What it should cover:
302300

303301
- tracked git content scanned with `gitleaks` or equivalent
304302
- CodeQL or equivalent static analysis
305-
- dependency review on pull requests
303+
- optional dependency review on pull requests if it behaves cleanly for the dependency ecosystems in the repo
306304
- generated license inventories for package ecosystems in the repo
307305
- SBOM artifacts for source and release artifacts
308306
- private disclosure guidance
@@ -317,7 +315,7 @@ Generic takeaway:
317315

318316
- secret scanning is a near-default for public repos
319317
- CodeQL or equivalent static analysis is a strong baseline for maintained starters
320-
- dependency review gives fast signal before risky packages land
318+
- dependency review can be useful, but it should be kept non-blocking or removed if it creates more noise than signal
321319
- non-blocking license reporting is a good bridge before stricter allowlist enforcement
322320
- SBOM generation is a strong supply-chain visibility layer for deployable templates
323321

@@ -432,9 +430,7 @@ soon.md
432430
.github/ISSUE_TEMPLATE/*
433431
.github/release-drafter.yml
434432
.github/labels.json
435-
.github/dependency-review-config.yml
436433
.github/workflows/template-ci.yml
437-
.github/workflows/dependency-review.yml
438434
.github/workflows/release-drafter.yml
439435
.github/workflows/release.yml
440436
.github/workflows/release-smoke.yml
@@ -456,6 +452,8 @@ Add these if relevant:
456452
scripts/check-contract-drift.mjs
457453
scripts/check-docker-builds.mjs
458454
scripts/check-release-smoke.mjs
455+
.github/dependency-review-config.yml
456+
.github/workflows/dependency-review.yml
459457
docs/assets/*
460458
docs/openapi.yaml
461459
tests/fixtures/*
@@ -498,7 +496,7 @@ For most future non-domain-specific starters, preserve this rough shape:
498496
- app, test, and build verification
499497
- browser E2E when the product story promises real workflows
500498
- platform-specific verification if relevant
501-
- dependency review
499+
- optional dependency review if it is trustworthy for the repo
502500
- Docker or packaging check if deployable
503501

504502
### Release Layer
@@ -558,7 +556,6 @@ If you want the version that scales better for open source or long-term reuse, a
558556
- `LICENSE`
559557
- workflow lint
560558
- CodeQL
561-
- dependency review
562559
- label sync
563560
- release drafter
564561
- release smoke tests
@@ -608,7 +605,7 @@ These patterns are still generic even though the local implementation is CV-shap
608605
- repos with real user flows should have at least one browser E2E confidence path
609606
- workflows should be linted
610607
- secrets should be scanned
611-
- dependency changes should be reviewed on pull requests
608+
- dependency changes should be reviewed on pull requests when the signal is reliable enough to justify the maintenance cost
612609
- dependency licenses should be reportable without manual digging
613610
- SBOMs should be generated for source trees or release artifacts when supply-chain visibility matters
614611
- published artifacts should have provenance attestations when the platform supports them

0 commit comments

Comments
 (0)