Skip to content

feat: ShopNotificationService 클래스 추가#2255

Merged
Soundbar91 merged 4 commits into
developfrom
feat/2254-add-shop-notification-service
May 24, 2026
Merged

feat: ShopNotificationService 클래스 추가#2255
Soundbar91 merged 4 commits into
developfrom
feat/2254-add-shop-notification-service

Conversation

@Soundbar91
Copy link
Copy Markdown
Collaborator

🔍 개요


🚀 주요 변경 내용

ShopNotificationService 클래스 추가

  • Shop 관련 도메인의 알림을 담당하는 클래스를 추가했습니다.
  • 관련 EventListener 클래스에 있는 Shop 관련 비즈니스 로직을 옮겼습니다.

💬 참고 사항


✅ Checklist (완료 조건)

  • 코드 스타일 가이드 준수
  • 테스트 코드 포함됨
  • Reviewers / Assignees / Labels 지정 완료
  • 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

@Soundbar91 Soundbar91 self-assigned this May 20, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

Warning

Review limit reached

@Soundbar91, we couldn't start this review because you've used your available PR reviews for now.

Your plan currently allows 1 review/hour. Refill in 45 minutes and 18 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8e9893be-ccb3-4017-88fd-17eeb4a8dbc2

📥 Commits

Reviewing files that changed from the base of the PR and between 640ca16 and 4e63d48.

📒 Files selected for processing (2)
  • src/main/java/in/koreatech/koin/domain/notification/eventlistener/ShopEventListener.java
  • src/main/java/in/koreatech/koin/domain/notification/service/ShopNotificationService.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/2254-add-shop-notification-service

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the 공통 백엔드 공통으로 작업할 이슈입니다. label May 20, 2026
@github-actions github-actions Bot requested review from dh2906 and kih1015 May 20, 2026 11:16
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

Unit Test Results

672 tests   669 ✔️  1m 19s ⏱️
166 suites      3 💤
166 files        0

Results for commit 4e63d48.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Collaborator

@BaeJinho4028 BaeJinho4028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Soundbar91 Soundbar91 merged commit 9c43277 into develop May 24, 2026
6 checks passed
@Soundbar91 Soundbar91 deleted the feat/2254-add-shop-notification-service branch May 24, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

공통 백엔드 공통으로 작업할 이슈입니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[공통] ShopNotificationService 클래스 추가

2 participants