Skip to content

Latest commit

 

History

History
10 lines (7 loc) · 1.27 KB

File metadata and controls

10 lines (7 loc) · 1.27 KB

Next major release

Breaking changes deferred to the next major version. The SDKs version in lockstep on major.minor, so these ship in the same release as the other SDKs' deferred changes. When one lands, move it to CHANGELOG.md and delete it here.

login() fires on_failure once on a network failure

  • Now (1.4.x): when /auth/validate is still unreachable after the network retry, login() calls on_failure("network_error", exc) from _post_json and then on_failure("login_failed", exc), and returns False. Without an on_failure callback the first call exits the process, so the exit happens on network_error. Check-in network failures already fire once (1.4.0).
  • Planned: fire once, as on_failure("login_failed", exc) where exc.code is network_error or timeout, matching check-ins and the C++ SDK. Same change as the C# SDK's Login().
  • Why deferred: callers that react to the network_error reason would stop seeing it, and callers counting callbacks would see one instead of two.
  • Touches: the _post_json("/auth/validate", body) call in _validate_and_store (authforge.py; pass skip_failure_hook=True), a login network-failure test, the "network_error (login only)" reason in README.md / AGENTS.md, AuthForgeDocs sdk/python.mdx.