Create a retry mechanism (retry API calls when failed)

[Ntnelbaba]

We are using this action with v1.3.
From time to time, it fails over timeout from the API and throws error code 598 even if there is a valid Asana link
It fails after 2 minutes with this error and does not try to recover.
Please add some retry mechanisms and minimize the timeout to the minimum.

[dgolombek]

This is happening for us as well, and seems to happen nearly every day around 11am EST -- I suspect there's a backend job at Asana that triggers around that time? It seems like just changing
https://github.com/Asana/create-app-attachment-github-action/blob/main/src/requests/axios.ts#L20
to cover 598's would solve this quite possibly.

[dgolombek]

I went to implement my suggestion above, but realized that it won't help -- AFAICT, the 598s persist for about 30 minutes, starting closer to 10:45am EST. The retry mechanism delays 3 times, for 1s, 2s, and 3s respectively, which will all fail. I think that #38 is the better solution here.

[CrystalDesignDR]

We have the same issues for over a month now, the Asana middleweare at https://github.integrations.asana.plus/custom/v1 is probably overloaded during this timeframe, because the normal Asana API at https://app.asana.com/api/1.0 during the same time period is working just fine.

We have an asana support case open for over 3 weeks now, with the latest status I’ve flagged this for further review by our engineering team ...

[swrobel]

Has anyone determined whether this actually prevents the attachment from being created in Asana? I was just debugging this issue in our integration, and spot-checking a few Asana tasks showed they still had the Github attachments, despite all of their Create Attachment Github actions failing with 598

[CrystalDesignDR]

For what I can tell attachements are being created in Asana just fine.
Still quite painful for us, because this is a required status check that needs to pass before PRs can be merged.

[dgolombek]

We rarely see the attachment created in Asana if the request fails -- maybe 20% of the time for us.

[kevino-haus]

We are still seeing this issue in August. This has been random and is now becoming more noticeable. Can you please provide an update on adding a retry mechanism to this action?

Unable to serve response within time limit.
Error: Request failed with status code 598

[CrystalDesignDR]

We also saw issues in the last four days, but it seems to be working atm, we did have a support case open for about 3 months, even doing their job by pointing at the issue at their middleware https://github.integrations.asana.plus/custom/v1.
But support wasn't helpful at all....

[cacarico]

We are seem this issue constantly recently.
Do you have any information? The issue above mentioned was closed but it didn't seem to solve this issue.

[CrystalDesignDR]

We also see issues recently.
We currently have a support case open with asana.

[CrystalDesignDR]

We have had a support case open for about 2 months now, the final status is as follows:

I have an update from our Engineering team regarding the issue you reported. Thank you for being so patient here. 
At this time, we are prioritising a high volume of broader integration improvements, which means we aren't able to slot this specific fix into our immediate roadmap.
Unfortunately, we don't have an ETA on when this might be solved. Rest assured, this has been documented and logged for our product team to review for future updates.
I'll go ahead and set this ticket to closed for now, but please don't hesitate to reach back out if you have any other questions. 

[cacarico]

Thx for sharing your case @CrystalDesignDR.
I gave up waiting for them and started creating integrations myself