From 5908ec31f2ec4a360c85b4758613107a459b3341 Mon Sep 17 00:00:00 2001 From: strtgbb <146047128+strtgbb@users.noreply.github.com> Date: Wed, 20 May 2026 09:20:01 -0400 Subject: [PATCH 1/5] fix SourceUpload job running when it shouldn't --- .github/workflows/master.yml | 2 +- .github/workflows/pull_request.yml | 2 +- .github/workflows/release_builds.yml | 2 +- ci/praktika/yaml_additional_templates.py | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml index 086b5d555d2a..4510ca9f6716 100644 --- a/.github/workflows/master.yml +++ b/.github/workflows/master.yml @@ -5525,7 +5525,7 @@ jobs: SourceUpload: needs: [config_workflow, build_amd_release] - if: ${{ !failure() && !cancelled() }} + if: ${{ !cancelled() && needs.config_workflow.outputs.pipeline_status != '' && !contains(needs.*.outputs.pipeline_status, 'failure') }} runs-on: [self-hosted, altinity-on-demand, altinity-style-checker-aarch64] env: COMMIT_SHA: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }} diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index adb30ada0e61..021822c1315c 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -5277,7 +5277,7 @@ jobs: SourceUpload: needs: [config_workflow, build_amd_release] - if: ${{ !failure() && !cancelled() }} + if: ${{ !cancelled() && needs.config_workflow.outputs.pipeline_status != '' && !contains(needs.*.outputs.pipeline_status, 'failure') }} runs-on: [self-hosted, altinity-on-demand, altinity-style-checker-aarch64] env: COMMIT_SHA: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }} diff --git a/.github/workflows/release_builds.yml b/.github/workflows/release_builds.yml index e67180011433..b886e8117e09 100644 --- a/.github/workflows/release_builds.yml +++ b/.github/workflows/release_builds.yml @@ -1115,7 +1115,7 @@ jobs: SourceUpload: needs: [config_workflow, build_amd_release] - if: ${{ !failure() && !cancelled() }} + if: ${{ !cancelled() && needs.config_workflow.outputs.pipeline_status != '' && !contains(needs.*.outputs.pipeline_status, 'failure') }} runs-on: [self-hosted, altinity-on-demand, altinity-style-checker-aarch64] env: COMMIT_SHA: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }} diff --git a/ci/praktika/yaml_additional_templates.py b/ci/praktika/yaml_additional_templates.py index fd71b5a2370b..b8ac1d40dce0 100644 --- a/ci/praktika/yaml_additional_templates.py +++ b/ci/praktika/yaml_additional_templates.py @@ -127,7 +127,7 @@ class AltinityWorkflowTemplates: "SourceUpload": r""" SourceUpload: needs: [config_workflow, build_amd_release] - if: ${{ !failure() && !cancelled() }} + if: ${{ !cancelled() && needs.config_workflow.outputs.pipeline_status != '' && !contains(needs.*.outputs.pipeline_status, 'failure') }} runs-on: [self-hosted, altinity-on-demand, altinity-style-checker-aarch64] env: COMMIT_SHA: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }} From fe128f993cf7fe42104e2d6933d8fc89f1f4bbd8 Mon Sep 17 00:00:00 2001 From: strtgbb <146047128+strtgbb@users.noreply.github.com> Date: Wed, 20 May 2026 09:35:35 -0400 Subject: [PATCH 2/5] same patch for finish jobs --- .github/workflows/master.yml | 4 ++-- .github/workflows/pull_request.yml | 4 ++-- .github/workflows/release_builds.yml | 4 ++-- ci/praktika/yaml_additional_templates.py | 2 +- ci/praktika/yaml_generator.py | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml index 4510ca9f6716..4f7708f631ae 100644 --- a/.github/workflows/master.yml +++ b/.github/workflows/master.yml @@ -5272,7 +5272,7 @@ jobs: finish_workflow: runs-on: [self-hosted, altinity-on-demand, altinity-style-checker-aarch64] needs: [ast_fuzzer_amd_debug, ast_fuzzer_amd_msan, ast_fuzzer_amd_tsan, ast_fuzzer_amd_ubsan, ast_fuzzer_arm_asan, build_amd_asan, build_amd_binary, build_amd_coverage, build_amd_debug, build_amd_msan, build_amd_release, build_amd_tsan, build_amd_ubsan, build_arm_asan, build_arm_binary, build_arm_release, buzzhouse_amd_debug, buzzhouse_amd_msan, buzzhouse_amd_tsan, buzzhouse_amd_ubsan, buzzhouse_arm_asan, clickbench_amd_release, clickbench_arm_release, compatibility_check_amd_release, compatibility_check_arm_release, config_workflow, docker_keeper_image, docker_server_image, dockers_build_amd, dockers_build_arm, dockers_build_multiplatform_manifest, install_packages_amd_release, install_packages_arm_release, integration_tests_amd_asan_db_disk_old_analyzer_1_6, integration_tests_amd_asan_db_disk_old_analyzer_2_6, integration_tests_amd_asan_db_disk_old_analyzer_3_6, integration_tests_amd_asan_db_disk_old_analyzer_4_6, integration_tests_amd_asan_db_disk_old_analyzer_5_6, integration_tests_amd_asan_db_disk_old_analyzer_6_6, integration_tests_amd_binary_1_5, integration_tests_amd_binary_2_5, integration_tests_amd_binary_3_5, integration_tests_amd_binary_4_5, integration_tests_amd_binary_5_5, integration_tests_amd_msan_1_6, integration_tests_amd_msan_2_6, integration_tests_amd_msan_3_6, integration_tests_amd_msan_4_6, integration_tests_amd_msan_5_6, integration_tests_amd_msan_6_6, integration_tests_amd_tsan_1_6, integration_tests_amd_tsan_2_6, integration_tests_amd_tsan_3_6, integration_tests_amd_tsan_4_6, integration_tests_amd_tsan_5_6, integration_tests_amd_tsan_6_6, integration_tests_arm_binary_distributed_plan_1_4, integration_tests_arm_binary_distributed_plan_2_4, integration_tests_arm_binary_distributed_plan_3_4, integration_tests_arm_binary_distributed_plan_4_4, sqllogic_test, sqltest, stateless_tests_amd_asan_db_disk_distributed_plan_sequential, stateless_tests_amd_asan_distributed_plan_parallel_1_4, stateless_tests_amd_asan_distributed_plan_parallel_2_4, stateless_tests_amd_asan_distributed_plan_parallel_3_4, stateless_tests_amd_asan_distributed_plan_parallel_4_4, stateless_tests_amd_coverage_1_8, stateless_tests_amd_coverage_2_8, stateless_tests_amd_coverage_3_8, stateless_tests_amd_coverage_4_8, stateless_tests_amd_coverage_5_8, stateless_tests_amd_coverage_6_8, stateless_tests_amd_coverage_7_8, stateless_tests_amd_coverage_8_8, stateless_tests_amd_debug_distributed_plan_s3_storage_parallel, stateless_tests_amd_debug_distributed_plan_s3_storage_sequential, stateless_tests_amd_debug_parallel, stateless_tests_amd_debug_sequential, stateless_tests_amd_msan_wasmedge_parallel_1_4, stateless_tests_amd_msan_wasmedge_parallel_2_4, stateless_tests_amd_msan_wasmedge_parallel_3_4, stateless_tests_amd_msan_wasmedge_parallel_4_4, stateless_tests_amd_msan_wasmedge_sequential_1_2, stateless_tests_amd_msan_wasmedge_sequential_2_2, stateless_tests_amd_tsan_parallel_1_2, stateless_tests_amd_tsan_parallel_2_2, stateless_tests_amd_tsan_s3_storage_parallel_1_2, stateless_tests_amd_tsan_s3_storage_parallel_2_2, stateless_tests_amd_tsan_s3_storage_sequential_1_2, stateless_tests_amd_tsan_s3_storage_sequential_2_2, stateless_tests_amd_tsan_sequential_1_2, stateless_tests_amd_tsan_sequential_2_2, stateless_tests_amd_ubsan_parallel, stateless_tests_amd_ubsan_sequential, stateless_tests_arm_asan_azure_parallel_1_4, stateless_tests_arm_asan_azure_parallel_2_4, stateless_tests_arm_asan_azure_parallel_3_4, stateless_tests_arm_asan_azure_parallel_4_4, stateless_tests_arm_asan_azure_sequential_1_2, stateless_tests_arm_asan_azure_sequential_2_2, stateless_tests_arm_binary_parallel, stateless_tests_arm_binary_sequential, stress_test_amd_debug, stress_test_amd_msan, stress_test_amd_release, stress_test_amd_tsan, stress_test_amd_ubsan, stress_test_arm_asan, stress_test_arm_asan_s3, stress_test_azure_amd_msan, stress_test_azure_amd_tsan, unit_tests_asan, unit_tests_msan, unit_tests_tsan, unit_tests_ubsan] - if: ${{ always() }} + if: ${{ always() && needs.config_workflow.outputs.pipeline_status != '' }} name: "Finish Workflow" outputs: data: ${{ steps.run.outputs.DATA }} @@ -5385,7 +5385,7 @@ jobs: data: ${{ needs.config_workflow.outputs.data }} FinishCIReport: - if: ${{ !cancelled() }} + if: ${{ !cancelled() && needs.config_workflow.outputs.pipeline_status != '' }} needs: - config_workflow - dockers_build_amd diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 021822c1315c..b6f96e3a7cbc 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -5050,7 +5050,7 @@ jobs: finish_workflow: runs-on: [self-hosted, altinity-on-demand, altinity-style-checker-aarch64] needs: [ast_fuzzer_amd_debug, ast_fuzzer_amd_debug_targeted, ast_fuzzer_amd_debug_targeted_old_compatibility, ast_fuzzer_amd_msan, ast_fuzzer_amd_tsan, ast_fuzzer_amd_ubsan, ast_fuzzer_arm_asan, build_amd_asan, build_amd_binary, build_amd_debug, build_amd_msan, build_amd_release, build_amd_tsan, build_amd_ubsan, build_arm_asan, build_arm_binary, build_arm_release, build_arm_tsan, build_toolchain_pgo_bolt_aarch64, build_toolchain_pgo_bolt_amd64, buzzhouse_amd_debug, buzzhouse_amd_msan, buzzhouse_amd_tsan, buzzhouse_amd_ubsan, buzzhouse_arm_asan, compatibility_check_amd_release, compatibility_check_arm_release, config_workflow, docker_keeper_image, docker_server_image, dockers_build_amd, dockers_build_arm, dockers_build_multiplatform_manifest, fast_test, install_packages_amd_release, install_packages_arm_release, integration_tests_amd_asan_db_disk_old_analyzer_1_6, integration_tests_amd_asan_db_disk_old_analyzer_2_6, integration_tests_amd_asan_db_disk_old_analyzer_3_6, integration_tests_amd_asan_db_disk_old_analyzer_4_6, integration_tests_amd_asan_db_disk_old_analyzer_5_6, integration_tests_amd_asan_db_disk_old_analyzer_6_6, integration_tests_amd_asan_targeted, integration_tests_amd_binary_1_5, integration_tests_amd_binary_2_5, integration_tests_amd_binary_3_5, integration_tests_amd_binary_4_5, integration_tests_amd_binary_5_5, integration_tests_amd_msan_1_6, integration_tests_amd_msan_2_6, integration_tests_amd_msan_3_6, integration_tests_amd_msan_4_6, integration_tests_amd_msan_5_6, integration_tests_amd_msan_6_6, integration_tests_amd_tsan_1_6, integration_tests_amd_tsan_2_6, integration_tests_amd_tsan_3_6, integration_tests_amd_tsan_4_6, integration_tests_amd_tsan_5_6, integration_tests_amd_tsan_6_6, integration_tests_arm_binary_distributed_plan_1_4, integration_tests_arm_binary_distributed_plan_2_4, integration_tests_arm_binary_distributed_plan_3_4, integration_tests_arm_binary_distributed_plan_4_4, quick_functional_tests, sqllogic_test, stateless_tests_amd_asan_db_disk_distributed_plan_sequential, stateless_tests_amd_asan_distributed_plan_parallel_1_4, stateless_tests_amd_asan_distributed_plan_parallel_2_4, stateless_tests_amd_asan_distributed_plan_parallel_3_4, stateless_tests_amd_asan_distributed_plan_parallel_4_4, stateless_tests_amd_debug_distributed_plan_s3_storage_parallel, stateless_tests_amd_debug_distributed_plan_s3_storage_sequential, stateless_tests_amd_debug_parallel, stateless_tests_amd_debug_sequential, stateless_tests_amd_msan_wasmedge_parallel_1_4, stateless_tests_amd_msan_wasmedge_parallel_2_4, stateless_tests_amd_msan_wasmedge_parallel_3_4, stateless_tests_amd_msan_wasmedge_parallel_4_4, stateless_tests_amd_msan_wasmedge_sequential_1_2, stateless_tests_amd_msan_wasmedge_sequential_2_2, stateless_tests_amd_tsan_parallel_1_2, stateless_tests_amd_tsan_parallel_2_2, stateless_tests_amd_tsan_s3_storage_parallel_1_2, stateless_tests_amd_tsan_s3_storage_parallel_2_2, stateless_tests_amd_tsan_s3_storage_sequential_1_2, stateless_tests_amd_tsan_s3_storage_sequential_2_2, stateless_tests_amd_tsan_sequential_1_2, stateless_tests_amd_tsan_sequential_2_2, stateless_tests_amd_ubsan_parallel, stateless_tests_amd_ubsan_sequential, stateless_tests_arm_asan_azure_parallel_1_4, stateless_tests_arm_asan_azure_parallel_2_4, stateless_tests_arm_asan_azure_parallel_3_4, stateless_tests_arm_asan_azure_parallel_4_4, stateless_tests_arm_asan_azure_sequential_1_2, stateless_tests_arm_asan_azure_sequential_2_2, stateless_tests_arm_asan_targeted, stateless_tests_arm_binary_parallel, stateless_tests_arm_binary_sequential, stress_test_amd_debug, stress_test_amd_msan, stress_test_amd_release, stress_test_amd_tsan, stress_test_amd_ubsan, stress_test_arm_asan, stress_test_arm_asan_s3, unit_tests_asan, unit_tests_msan, unit_tests_tsan, unit_tests_ubsan] - if: ${{ always() }} + if: ${{ always() && needs.config_workflow.outputs.pipeline_status != '' }} name: "Finish Workflow" outputs: data: ${{ steps.run.outputs.DATA }} @@ -5144,7 +5144,7 @@ jobs: workflow_config: ${{ needs.config_workflow.outputs.data }} FinishCIReport: - if: ${{ !cancelled() }} + if: ${{ !cancelled() && needs.config_workflow.outputs.pipeline_status != '' }} needs: - config_workflow - dockers_build_amd diff --git a/.github/workflows/release_builds.yml b/.github/workflows/release_builds.yml index b886e8117e09..41d2874cbc3f 100644 --- a/.github/workflows/release_builds.yml +++ b/.github/workflows/release_builds.yml @@ -983,7 +983,7 @@ jobs: finish_workflow: runs-on: [self-hosted, altinity-on-demand, altinity-style-checker-aarch64] needs: [build_amd_asan, build_amd_binary, build_amd_debug, build_amd_msan, build_amd_release, build_amd_tsan, build_amd_ubsan, build_arm_asan, build_arm_binary, build_arm_release, config_workflow, docker_keeper_image, docker_server_image, dockers_build_amd, dockers_build_arm, dockers_build_multiplatform_manifest, install_packages_amd_release, install_packages_arm_release, stateless_tests_arm_binary_parallel, stateless_tests_arm_binary_sequential] - if: ${{ always() }} + if: ${{ always() && needs.config_workflow.outputs.pipeline_status != '' }} name: "Finish Workflow" outputs: data: ${{ steps.run.outputs.DATA }} @@ -1073,7 +1073,7 @@ jobs: data: ${{ needs.config_workflow.outputs.data }} FinishCIReport: - if: ${{ !cancelled() }} + if: ${{ !cancelled() && needs.config_workflow.outputs.pipeline_status != '' }} needs: - config_workflow - dockers_build_amd diff --git a/ci/praktika/yaml_additional_templates.py b/ci/praktika/yaml_additional_templates.py index b8ac1d40dce0..b4f414eee704 100644 --- a/ci/praktika/yaml_additional_templates.py +++ b/ci/praktika/yaml_additional_templates.py @@ -108,7 +108,7 @@ class AltinityWorkflowTemplates: """, "CIReport": r""" FinishCIReport: - if: ${{ !cancelled() }} + if: ${{ !cancelled() && needs.config_workflow.outputs.pipeline_status != '' }} needs: {ALL_JOBS} runs-on: [self-hosted, altinity-on-demand, altinity-style-checker-aarch64] diff --git a/ci/praktika/yaml_generator.py b/ci/praktika/yaml_generator.py index 15b95f87a7a2..af184588e09d 100644 --- a/ci/praktika/yaml_generator.py +++ b/ci/praktika/yaml_generator.py @@ -243,7 +243,7 @@ class Templates: """ TEMPLATE_IF_EXPRESSION_ALWAYS = """ - if: ${{ always() }}\ + if: ${{ always() && needs.config_workflow.outputs.pipeline_status != '' }}\ """ def __init__(self): From 63d72a429e0d3e0b778560cb140f4732ade144a2 Mon Sep 17 00:00:00 2001 From: strtgbb <146047128+strtgbb@users.noreply.github.com> Date: Wed, 20 May 2026 09:36:54 -0400 Subject: [PATCH 3/5] fix fast_test in community workflow --- ci/jobs/fast_test.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ci/jobs/fast_test.py b/ci/jobs/fast_test.py index 0e996147ccb2..90dae093da32 100644 --- a/ci/jobs/fast_test.py +++ b/ci/jobs/fast_test.py @@ -175,6 +175,9 @@ def main(): if info.is_local_run or info.is_community_pr: print("NOTE: Community contribution or local run - set sccache to run without AWS credentials") os.environ["SCCACHE_S3_NO_CREDENTIALS"] = "true" + # NOTE (strtgbb): sccache will throw an error if AWS credentials are present with SCCACHE_S3_NO_CREDENTIALS=1 + os.environ.pop("AWS_SECRET_ACCESS_KEY", None) + os.environ.pop("AWS_ACCESS_KEY_ID", None) else: pass # NOTE (strtgbb): Not used yet, but we should look into setting up the secrets for it From 0aee468f7d9830e7b1ccd9f196cc10725335987b Mon Sep 17 00:00:00 2001 From: strtgbb <146047128+strtgbb@users.noreply.github.com> Date: Wed, 20 May 2026 12:19:51 -0400 Subject: [PATCH 4/5] don't created Targeter in community PR --- ci/jobs/functional_tests.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ci/jobs/functional_tests.py b/ci/jobs/functional_tests.py index ed24514ad403..84775a71137e 100644 --- a/ci/jobs/functional_tests.py +++ b/ci/jobs/functional_tests.py @@ -363,7 +363,11 @@ def main(): if not has_stateful: has_stateful_tests = False - targeter = Targeting(info=info) + if not info.is_community_pr: + targeter = Targeting(info=info) + else: + targeter = None + if is_flaky_check or is_bugfix_validation: if info.is_local_run: assert ( From b09e214dc7f459fa711e7137afb0c85e4d85f520 Mon Sep 17 00:00:00 2001 From: strtgbb <146047128+strtgbb@users.noreply.github.com> Date: Wed, 20 May 2026 20:34:12 -0400 Subject: [PATCH 5/5] update broken_tests.yaml --- tests/broken_tests.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/broken_tests.yaml b/tests/broken_tests.yaml index 0e8ecc80af27..156e07ec5caf 100644 --- a/tests/broken_tests.yaml +++ b/tests/broken_tests.yaml @@ -60,22 +60,22 @@ - msan - name: 02313_filesystem_cache_seeks reason: fails when azure storage is not set up - message: 'DB::Exception: Cannot wrap disk `azure` with cache layer' + message: 'azure' - name: 02286_drop_filesystem_cache reason: fails when azure storage is not set up - message: 'DB::Exception: Cannot wrap disk `azure` with cache layer' + message: 'azure' - name: 02242_system_filesystem_cache_log_table reason: fails when azure storage is not set up - message: 'DB::Exception: Cannot wrap disk `azure` with cache layer' + message: 'azure' - name: 02241_filesystem_cache_on_write_operations reason: fails when azure storage is not set up - message: 'DB::Exception: Cannot wrap disk `azure` with cache layer' + message: 'azure' - name: 02240_system_filesystem_cache_table reason: fails when azure storage is not set up - message: 'DB::Exception: Cannot wrap disk `azure` with cache layer' + message: 'azure' - name: 02226_filesystem_cache_profile_events reason: fails when azure storage is not set up - message: 'DB::Exception: Cannot wrap disk `azure` with cache layer' + message: 'azure' - name: 00024_random_counters reason: INVESTIGATE - random timeout message: Timeout! Processes left in process group