Fix unused variables, parameters, values

Fixes errors from the following Clang-Tidy categories:

- `clang-analyzer-deadcode.DeadStores`
- `clang-diagnostic-unused-parameter`
- `clang-diagnostic-unused-variable`

Most errors are fixed temporarily by commenting out the unused bits and by adding a `FIXME: unused` comment.

The final fix is to either remove the unused bits or to fix the bugs which has to be done by someone who knows the intended behaviour.

Author: vkucera

PWGMM/Lumi/Tasks/lumiStability.cxx

@@ -276,11 +276,11 @@ struct LumiStabilityTask {
     int executionCounter = 0;
     int nbin = o2::constants::lhc::LHCMaxBunches;
     uint32_t nOrbitsPerTF = 0; // 128 in 2022, 32 in 2023
-    if (is2022Data) {
-      nOrbitsPerTF = 128; // 128 in 2022, 32 in 2023
-    } else {
-      nOrbitsPerTF = 32; // 128 in 2022, 32 in 2023
-    }
+    // if (is2022Data) {
+    //   nOrbitsPerTF = 128; // 128 in 2022, 32 in 2023 // FIXME: unused
+    // } else {
+    //   nOrbitsPerTF = 32; // 128 in 2022, 32 in 2023 // FIXME: unused
+    // }
     int runNumber = bcs.iteratorAt(0).runNumber();
     if (runNumber != lastRunNumber && executionCounter < 1) {
       tsSOR = 0;
@@ -497,8 +497,8 @@ struct LumiStabilityTask {
             pastActivityFDDVertex |= (vertexPast);
           }
         }
-        deltaIndex = 0;
-        deltaBC = 0;
+        // deltaIndex = 0; // FIXME: unused
+        // deltaBC = 0; // FIXME: unused
 
         if (pastActivityFDDVertex == false) {
           histos.fill(HIST("FDD/hCounts"), 2);
@@ -645,8 +645,8 @@ struct LumiStabilityTask {
               pastActivityFDDTriggerCCoincidenceC |= (triggerCPast & isCoinCPast);
             }
           }
-          deltaIndex = 0;
-          deltaBC = 0;
+          // deltaIndex = 0; // FIXME: unused
+          // deltaBC = 0; // FIXME: unused
 
           if (pastActivityFDDVertexCoincidences == false) {
             histos.fill(HIST("FDD/hCounts"), 4);
@@ -782,8 +782,8 @@ struct LumiStabilityTask {
             pastActivityFT0TriggerC |= triggerCPast;
           }
         }
-        deltaIndex = 0;
-        deltaBC = 0;
+        // deltaIndex = 0; // FIXME: unused
+        // deltaBC = 0; // FIXME: unused
 
         histos.fill(HIST("FT0/hCounts"), 1);
         if (pastActivityFT0Vertex == false) {

PWGMM/Lumi/macros/merger.C

@@ -30,7 +30,7 @@ void merger()
   TFile* fout = new TFile("mergedOutput.root", "recreate");
   TTree* tin = new TTree("EventInfo_merged", "");
 
-  TList* list = fin->GetListOfKeys();
+  // TList* list = fin->GetListOfKeys(); // FIXME: unused
   TIter next(fin->GetListOfKeys());
 
   ULong64_t fTimeStamp;

PWGMM/Lumi/macros/non_fac.C

@@ -45,7 +45,7 @@ double tmax;
 
 int Countig;
 
-void chi2(Int_t& npar, Double_t* gin, Double_t& f, Double_t* par, Int_t flag)
+void chi2(Int_t& /*npar*/, Double_t* /*gin*/, Double_t& f, Double_t* par, Int_t /*flag*/)
 {
   TMatrixD sigma(2, 2);
   double results = 0.;
@@ -241,4 +241,5 @@ void non_fac()
   for (int i = 0; i < 10; i++) {
     hParam[i]->Write();
   }
+  fout->Close();
 }

PWGMM/Mult/TableProducer/ambiguousTrackPropagation.cxx

@@ -292,7 +292,7 @@ struct AmbiguousTrackPropagation {
     o2::track::TrackParCovFwd bestTrackPar;
 
     for (auto const& atrack : atracks) {
-      dcaInfo = 999; // DCAxy
+      // dcaInfo = 999; // DCAxy // FIXME: unused
       bestDCA = 999;
 
       auto track = atrack.mfttrack();
@@ -375,7 +375,7 @@ struct AmbiguousTrackPropagation {
     o2::track::TrackParCovFwd bestTrackPar;
 
     for (auto const& track : tracks) {
-      dcaInfo = 999; // DCAxy
+      // dcaInfo = 999; // DCAxy // FIXME: unused
       bestDCA = 999;
 
       auto bestCol = track.has_collision() ? track.collisionId() : -1;

PWGMM/Mult/Tasks/dndeta-hi.cxx

@@ -835,7 +835,7 @@ struct MultiplicityCounter {
         auto pTrack = v0.template posTrack_as<DaughterTracks>();
         auto nTrack = v0.template negTrack_as<DaughterTracks>();
 
-        if (0 && v0.v0radius() > v0radius &&
+        if (0 && v0.v0radius() > v0radius && // FIXME: always false
             v0.v0cosPA() > v0cospa &&
             abs(pTrack.eta()) < etadau &&
             abs(nTrack.eta()) < etadau) {

PWGMM/Mult/Tasks/vertexing-fwd.cxx

@@ -148,7 +148,7 @@ struct vertexingfwd {
 
     for (auto& atrack : atracks) {
 
-      dcaXY = 999; // DCAxy
+      // dcaXY = 999; // DCAxy // FIXME: unused
       bestDCA = 999;
 
       auto track = atrack.mfttrack_as<MFTTracksLabeled>();