Exception handling for getDb, getTrackDb

Author: Changhwan Choi

PWGJE/Core/JetTaggingUtilities.h

@@ -1229,6 +1229,9 @@ T getDbFromProb(const std::vector<T>& probs, double fC = 0.018)
 template <typename T>
 T getDb(const std::vector<T>& logits, double fC = 0.018)
 {
+  if (logits.size() < 3) {
+    LOG(fatal) << "getDb expects at least 3 class logits, received " << logits.size();
+  }
   auto softmax = [](const std::vector<T>& logits) {
     std::vector<T> res;
     T maxLogit = *std::max_element(logits.begin(), logits.end());
@@ -1245,11 +1248,13 @@ T getDb(const std::vector<T>& logits, double fC = 0.018)
 
   std::vector<T> softmaxLogits = softmax(logits);
 
-  if (softmaxLogits[1] == 0. && softmaxLogits[2] == 0.) {
-    LOG(debug) << "jettaggingutilities::Db, Divide by zero: softmaxLogits = (" << softmaxLogits[0] << ", " << softmaxLogits[1] << ", " << softmaxLogits[2] << ")";
+  auto denominator = fC * softmaxLogits[1] + (1. - fC) * softmaxLogits[2];
+  if (!std::isfinite(softmaxLogits[0]) || !std::isfinite(denominator) || softmaxLogits[0] <= 0. || denominator <= 0.) {
+    LOG(debug) << "jettaggingutilities::getDb, non-positive or non-finite numerator/denominator";
+    return std::numeric_limits<T>::quiet_NaN();
   }
 
-  return std::log(softmaxLogits[0] / (fC * softmaxLogits[1] + (1. - fC) * softmaxLogits[2]));
+  return std::log(softmaxLogits[0] / denominator);
 }
 
 // Track-origin discriminant. Logit order: [background, charm, beauty, PV, other SV].
@@ -1273,8 +1278,9 @@ T getTrackDb(const std::vector<T>& trackLogits, double trackFC)
   }
 
   T denominator = trackFC * softmaxLogits[1] + (1. - trackFC) * (softmaxLogits[0] + softmaxLogits[3] + softmaxLogits[4]);
-  if (denominator == 0.) {
-    LOG(debug) << "jettaggingutilities::getTrackDb, zero denominator";
+  if (!std::isfinite(softmaxLogits[2]) || !std::isfinite(denominator) || softmaxLogits[2] <= 0. || denominator <= 0.) {
+    LOG(debug) << "jettaggingutilities::getTrackDb, non-positive or non-finite numerator/denominator";
+    return std::numeric_limits<T>::quiet_NaN();
   }
   return std::log(softmaxLogits[2] / denominator);
 }

PWGJE/TableProducer/jetGnnInference.cxx

@@ -243,7 +243,7 @@ struct JetGnnInferenceTask {
             LOG(fatal) << "GNN trackIndex is out of range for the track QA scores.";
           }
           float score = (*trackScores)[nodeIndex];
-          if (score == invalidGnnScore || std::isnan(score)) {
+          if (score == invalidGnnScore || !std::isfinite(score)) {
             continue;
           }
           registry.fill(HIST("h_trackDb"), score);
@@ -400,14 +400,14 @@ struct JetGnnInferenceTask {
           trackLogits[category] = nodeLogits[nodeIndex * trackLogits.size() + category];
         }
         float score = jettaggingutilities::getTrackDb(trackLogits, trackFC);
-        (*trackScores)[nodeIndex] = std::isnan(score) ? invalidGnnScore : score;
+        (*trackScores)[nodeIndex] = !std::isfinite(score) ? invalidGnnScore : score;
       }
     } else {
       auto const modelOutput = bMlResponse.getModelOutput(gnnInput, 0);
       db = jettaggingutilities::getDb(modelOutput, fC);
     }
-    if (std::isnan(db)) {
-      LOGF(debug, "GNN inference, Db is NaN (%d)", jet.globalIndex());
+    if (!std::isfinite(db)) {
+      LOGF(debug, "GNN inference, Db is non-finite (%d)", jet.globalIndex());
       return 999.f;
     }
     return db;

PWGJE/TableProducer/jetTaggerHF.cxx

@@ -653,11 +653,11 @@ struct JetTaggerHFTask {
 
         auto modelOutput = bMlResponse.getModelOutput(gnnInput, 0);
         float db = jettaggingutilities::getDb(modelOutput, fC);
-        if (!std::isnan(db)) {
+        if (std::isfinite(db)) {
           scoreML[jet.globalIndex()] = db;
         } else {
           scoreML[jet.globalIndex()] = 999.;
-          LOGF(debug, "doprocessAlgorithmGNNwExtra, Db is NaN (%d)", jet.globalIndex());
+          LOGF(debug, "doprocessAlgorithmGNNwExtra, Db is non-finite (%d)", jet.globalIndex());
         }
       } else {
         scoreML[jet.globalIndex()] = -999.;
@@ -682,11 +682,11 @@ struct JetTaggerHFTask {
 
         auto modelOutput = bMlResponse.getModelOutput(gnnInput, 0);
         float db = jettaggingutilities::getDb(modelOutput, fC);
-        if (!std::isnan(db)) {
+        if (std::isfinite(db)) {
           scoreML[jet.globalIndex()] = db;
         } else {
           scoreML[jet.globalIndex()] = 999.;
-          LOGF(debug, "doprocessAlgorithmGNN, Db is NaN (%d)", jet.globalIndex());
+          LOGF(debug, "doprocessAlgorithmGNN, Db is non-finite (%d)", jet.globalIndex());
         }
       } else {
         scoreML[jet.globalIndex()] = -999.;