Fix: fix linter warnings

Author: ariedel-cern

PWGCF/Femto/Core/femtoUtils.h

@@ -86,10 +86,10 @@ float itsSignal(T const& track)
 // internally by TDatabasePDG's particle-table construction) and no mass constant exists in
 // PhysicsConstants.h either, so both the codes and the mass are hardcoded here, same as kRho770_0/
 // kRho770Plus below.
-constexpr int kDeltaMinus1232 = 1114;
-constexpr int kDelta01232 = 2114;
-constexpr int kDeltaPlus1232 = 2214;
-constexpr int kDeltaPlusPlus1232 = 2224;
+constexpr int DeltaMinus1232 = 1114;
+constexpr int Delta01232 = 2114;
+constexpr int DeltaPlus1232 = 2214;
+constexpr int DeltaPlusPlus1232 = 2224;
 
 inline double getPdgMass(int pdgCode)
 {
@@ -158,10 +158,10 @@ inline double getPdgMass(int pdgCode)
     case o2::constants::physics::kEta:
       mass = o2::constants::physics::MassEta;
       break;
-    case kDeltaMinus1232:
-    case kDelta01232:
-    case kDeltaPlus1232:
-    case kDeltaPlusPlus1232:
+    case DeltaMinus1232:
+    case Delta01232:
+    case DeltaPlus1232:
+    case DeltaPlusPlus1232:
       mass = 1.232; // not defined in O2?
       break;
     default:

PWGCF/Femto/Core/particleCleaner.h

@@ -47,9 +47,6 @@ struct ConfParticleCleaner : o2::framework::ConfigurableGroup {
   o2::framework::Configurable<float> motherPtMax{"motherPtMax", 1e6f, "Maximum pT of the mother. One shared window applies regardless of which requiredMotherPdgCodes/rejectMotherPdgCodes entry the mother's own pdg code matched"};
   o2::framework::Configurable<float> motherEtaMin{"motherEtaMin", -1e6f, "Minimum eta of the mother. One shared window applies regardless of which requiredMotherPdgCodes/rejectMotherPdgCodes entry the mother's own pdg code matched"};
   o2::framework::Configurable<float> motherEtaMax{"motherEtaMax", 1e6f, "Maximum eta of the mother. One shared window applies regardless of which requiredMotherPdgCodes/rejectMotherPdgCodes entry the mother's own pdg code matched"};
-  // Rapidity cut on the mother. FMcMothers has no mass column, so the mass is looked up from
-  // PdgCode via utils::getPdgMass() (the same lookup pairHistManager.h uses for kstar/Q3) and
-  // combined with the mother's pt/eta to get y -- see RecoDecay::y(pt, eta, m).
   o2::framework::Configurable<float> motherRapidityMin{"motherRapidityMin", -1e6f, "Minimum rapidity of the mother. One shared window applies regardless of which requiredMotherPdgCodes/rejectMotherPdgCodes entry the mother's own pdg code matched"};
   o2::framework::Configurable<float> motherRapidityMax{"motherRapidityMax", 1e6f, "Maximum rapidity of the mother. One shared window applies regardless of which requiredMotherPdgCodes/rejectMotherPdgCodes entry the mother's own pdg code matched"};
   o2::framework::Configurable<float> motherPhiMin{"motherPhiMin", 0.f, "Minimum phi of the mother. One shared window applies regardless of which requiredMotherPdgCodes/rejectMotherPdgCodes entry the mother's own pdg code matched"};
@@ -240,24 +237,15 @@ class ParticleCleaner
         }
       }
 
-      // One shared pt/eta/phi/rapidity window, applied to the mother regardless of which (if any)
-      // requiredMotherPdgCodes/rejectMotherPdgCodes entry it matched above -- see the comment on
-      // ConfParticleCleaner's motherPtMin et al.
+      // One shared pt/eta/phi window, applied to the mother regardless of which (if any)
+      // requiredMotherPdgCodes/rejectMotherPdgCodes entry it matched above
+      double motherRapidity = mother.y(utils::getPdgMass(mother.pdgCode()));
       if (!(mother.pt() > mMotherPtMin && mother.pt() < mMotherPtMax &&
             mother.eta() > mMotherEtaMin && mother.eta() < mMotherEtaMax &&
+            motherRapidity > mMotherRapidityMin && motherRapidity < mMotherRapidityMax &&
             mother.phi() > mMotherPhiMin && mother.phi() < mMotherPhiMax)) {
         motherKinematicsOk = false;
       }
-
-      // rapidity needs the mother's mass, which FMcMothers does not store directly -- its Y()
-      // dynamic column takes mass as a free argument, looked up from the pdg code (same mechanism
-      // as the kstar/Q3 mass lookup in pairHistManager.h)
-      if (mMotherRapidityMin > -1e6f || mMotherRapidityMax < 1e6f) {
-        double motherRapidity = mother.y(utils::getPdgMass(mother.pdgCode()));
-        if (!(motherRapidity > mMotherRapidityMin && motherRapidity < mMotherRapidityMax)) {
-          motherKinematicsOk = false;
-        }
-      }
     }
 
     // MC partonic mother — same idea, via mcParticle