Skip to content

Commit 9838179

Browse files
axti98axti98
committed
Fix Linter issues
1 parent 00d3e31 commit 9838179

3 files changed

Lines changed: 942 additions & 921 deletions

File tree

‎PWGDQ/Core/DQConstants.h‎

Lines changed: 112 additions & 82 deletions
Original file line numberDiff line numberDiff line change
@@ -21,149 +21,179 @@
2121
namespace o2::dqconstants
2222
{
2323
// Numerical conventions
24-
inline constexpr float kInvalidValue = -9999.f;
25-
inline constexpr int kInvalidNum = -9999;
26-
inline constexpr int kInvalidIndex = -1;
24+
inline constexpr float InvalidValue = -9999.f;
25+
inline constexpr int InvalidNum = -9999;
26+
inline constexpr int InvalidIndex = -1;
2727

28-
inline constexpr std::uint8_t kFlag8 = 0u;
29-
inline constexpr std::uint32_t kFlag32 = 0u;
30-
inline constexpr std::uint64_t kFlag64 = 0ull;
28+
inline constexpr std::uint8_t Flag8 = 0u;
29+
inline constexpr std::uint32_t Flag32 = 0u;
30+
inline constexpr std::uint64_t Flag64 = 0ull;
3131

32-
inline constexpr float kInvalidFloat = -1.0f;
33-
inline constexpr float kEmptyVariable = 0.0f;
32+
inline constexpr float InvalidFloat = -1.0f;
33+
inline constexpr float EmptyVariable = 0.0f;
3434

35-
inline constexpr double kMillisecondsPerMinute = 60000.0;
35+
inline constexpr double MillisecondsPerMinute = 60000.0;
3636

37-
inline constexpr int kTwoProng = 2;
38-
inline constexpr int kThreeProng = 3;
39-
inline constexpr int kFourProng = 4;
37+
inline constexpr int TwoProng = 2;
38+
inline constexpr int ThreeProng = 3;
39+
inline constexpr int FourProng = 4;
40+
41+
inline constexpr int TPCCalibTypeStart = 0;
42+
inline constexpr int TPCCalibTypeEnd = 2;
43+
44+
inline constexpr int InvalidDCA = 999;
4045

4146
// Checks
42-
inline constexpr auto isCoordinateValid = [](float value) constexpr -> bool {
47+
inline constexpr auto IsCoordinateValid = [](float value) constexpr -> bool {
4348
return value >= 0.f;
4449
};
4550

46-
inline constexpr auto isDCAInvalid = [](float value) constexpr -> bool {
47-
return value > 999;
51+
inline constexpr auto IsDCAInvalid = [](float value) constexpr -> bool {
52+
return value > InvalidDCA;
4853
};
4954

50-
inline constexpr auto isProcCodeInvalid = [](int procCode) constexpr -> bool {
55+
inline constexpr auto IsProcCodeInvalid = [](int procCode) constexpr -> bool {
5156
return procCode == 0;
5257
};
5358

54-
inline constexpr auto checkCalibrationTypeInvalid = [](int type) constexpr -> bool {
55-
return type < 0 || type > 2;
59+
inline constexpr auto CheckCalibrationTypeInvalid = [](int type) constexpr -> bool {
60+
return type < TPCCalibTypeStart || type > TPCCalibTypeEnd;
5661
};
5762

58-
inline constexpr auto getNumDegreesOfFreedom = [](int Ntrk) constexpr -> int {
59-
return 2*Ntrk - 3;
63+
inline constexpr auto GetNumDegreesOfFreedom = [](int Ntrk) constexpr -> int {
64+
return 2 * Ntrk - 3;
6065
};
6166

6267
// Shared histogram class names
6368
namespace histograms
6469
{
6570
// Event histograms names
66-
inline constexpr char kEventBeforeCuts[] = "Event_BeforeCuts";
67-
inline constexpr char kEventAfterCuts[] = "Event_AfterCuts";
68-
inline constexpr char kEventMCTruth[] = "Event_MCTruth";
71+
inline constexpr char EventBeforeCuts[] = "Event_BeforeCuts";
72+
inline constexpr char EventAfterCuts[] = "Event_AfterCuts";
73+
inline constexpr char EventMCTruth[] = "Event_MCTruth";
6974

7075
// Track histogram names
71-
inline constexpr char kTrackBarrelBeforeCuts[] = "TrackBarrel_BeforeCuts";
72-
inline constexpr char kTrackBarrelAfterCuts[] = "TrackBarrel_";
76+
inline constexpr char TrackBarrelBeforeCuts[] = "TrackBarrel_BeforeCuts";
77+
inline constexpr char TrackBarrelAfterCuts[] = "TrackBarrel_";
7378

74-
inline constexpr char kPairsBarrelSEPM[] = "PairsBarrelSEPM";
75-
inline constexpr char kPairsBarrelSEPP[] = "PairsBarrelSEPP";
76-
inline constexpr char kPairsBarrelSEMM[] = "PairsBarrelSEMM";
79+
inline constexpr char PairsBarrelSEPM[] = "PairsBarrelSEPM";
80+
inline constexpr char PairsBarrelSEPP[] = "PairsBarrelSEPP";
81+
inline constexpr char PairsBarrelSEMM[] = "PairsBarrelSEMM";
7782

78-
inline constexpr char kPairsBarrelMEPM[] = "PairsBarrelMEPM";
79-
inline constexpr char kPairsBarrelMEPP[] = "PairsBarrelMEPP";
80-
inline constexpr char kPairsBarrelMEMM[] = "PairsBarrelMEMM";
83+
inline constexpr char PairsBarrelMEPM[] = "PairsBarrelMEPM";
84+
inline constexpr char PairsBarrelMEPP[] = "PairsBarrelMEPP";
85+
inline constexpr char PairsBarrelMEMM[] = "PairsBarrelMEMM";
8186

8287
// Muon histogram names
83-
inline constexpr char kMuonBeforeCuts[] = "Muons_BeforeCuts";
84-
inline constexpr char kTrackMuonBeforeCuts[] = "TrackMuon_BeforeCuts";
85-
inline constexpr char kTrackMuonAfterCuts[] = "TrackMuon_";
88+
inline constexpr char MuonBeforeCuts[] = "Muons_BeforeCuts";
89+
inline constexpr char TrackMuonBeforeCuts[] = "TrackMuon_BeforeCuts";
90+
inline constexpr char TrackMuonAfterCuts[] = "TrackMuon_";
8691

87-
inline constexpr char kPairsMuonSEPM[] = "PairsMuonSEPM";
88-
inline constexpr char kPairsMuonSEPP[] = "PairsMuonSEPP";
89-
inline constexpr char kPairsMuonSEMM[] = "PairsMuonSEMM";
92+
inline constexpr char PairsMuonSEPM[] = "PairsMuonSEPM";
93+
inline constexpr char PairsMuonSEPP[] = "PairsMuonSEPP";
94+
inline constexpr char PairsMuonSEMM[] = "PairsMuonSEMM";
9095

91-
inline constexpr char kPairsMuonMEPM[] = "PairsMuonMEPM";
92-
inline constexpr char kPairsMuonMEPP[] = "PairsMuonMEPP";
93-
inline constexpr char kPairsMuonMEMM[] = "PairsMuonMEMM";
96+
inline constexpr char PairsMuonMEPM[] = "PairsMuonMEPM";
97+
inline constexpr char PairsMuonMEPP[] = "PairsMuonMEPP";
98+
inline constexpr char PairsMuonMEMM[] = "PairsMuonMEMM";
9499
} // namespace histograms
95100

96-
namespace devices {
97-
inline constexpr char kEventSelection[] = "analysis-event-selection";
98-
inline constexpr char kTrackSelection[] = "analysis-track-selection";
99-
inline constexpr char kMuonSelection[] = "analysis-muon-selection";
100-
inline constexpr char kPrefilterSelection[] = "analysis-prefilter-selection";
101-
inline constexpr char kSameEventPairing[] = "analysis-same-event-pairing";
102-
inline constexpr char kAsymmetricPairing[] = "analysis-asymmetric-pairing";
103-
inline constexpr char kDileptonTrack[] = "analysis-dilepton-track";
104-
inline constexpr char kDileptonTrackTrack[] = "analysis-dilepton-track-track";
101+
namespace devices
102+
{
103+
inline constexpr char EventSelection[] = "analysis-event-selection";
104+
inline constexpr char TrackSelection[] = "analysis-track-selection";
105+
inline constexpr char MuonSelection[] = "analysis-muon-selection";
106+
inline constexpr char PrefilterSelection[] = "analysis-prefilter-selection";
107+
inline constexpr char SameEventPairing[] = "analysis-same-event-pairing";
108+
inline constexpr char AsymmetricPairing[] = "analysis-asymmetric-pairing";
109+
inline constexpr char DileptonTrack[] = "analysis-dilepton-track";
110+
inline constexpr char DileptonTrackTrack[] = "analysis-dilepton-track-track";
105111
} // namespace devices
106112

107113
// Defaults
108114
namespace defaults
109115
{
110116
// Event selection defaults
111-
inline constexpr int kEventTagStartBit = 56;
112-
inline constexpr float kMaxAbsVertexZCm = 10.f;
113-
inline constexpr char kDefaultRCTLabel[] = "CBT";
117+
inline constexpr int EventTagStartBit = 56;
118+
inline constexpr float MaxAbsVertexZCm = 10.f;
119+
inline constexpr char DefaultRCTLabel[] = "CBT";
114120

115-
inline constexpr int kNumDalitzSelections = 8;
121+
inline constexpr int NumDalitzSelections = 8;
116122

117-
inline constexpr int kNumTPCPostCalibrationTypes = 4;
123+
inline constexpr int NumTPCPostCalibrationTypes = 4;
118124

119125
// Track defaults
120-
inline constexpr int kNumDCAPars = 2;
121-
inline constexpr int kIndexDCAxy = 0;
122-
inline constexpr int kIndexDCAz = 0;
123-
inline constexpr double kInitialDCA = 1e10;
126+
inline constexpr int NumDCAPars = 2;
127+
inline constexpr int IndexDCAxy = 0;
128+
inline constexpr int IndexDCAz = 0;
129+
inline constexpr double InitialDCA = 1e10;
130+
131+
inline constexpr int RotationType1 = 1;
132+
inline constexpr int RotationType2 = 2;
133+
inline constexpr int RotationType3 = 3;
134+
135+
inline constexpr int BdtSingleClassOutput = 1;
136+
inline constexpr int BdtMultiClassOutput = 1;
124137

125138
// Bimodality defaults
126-
inline constexpr float kBimodalityInvalidBinWidth = -1.0;
127-
inline constexpr float kBimodalityBinWidth = 0.005;
139+
inline constexpr int BimodalMinDataSize = 3;
140+
inline constexpr float BimodalityInvalidBinWidth = -1.0;
141+
inline constexpr float BimodalityBinWidth = 0.005;
142+
143+
inline constexpr float BimodalityDCAFrac001 = 0.01;
144+
inline constexpr float BimodalityDCAFrac002 = 0.02;
145+
inline constexpr float BimodalityDCAFrac005 = 0.05;
146+
inline constexpr float BimodalityDCAFrac01 = 0.1;
147+
inline constexpr float BimodalityDCAFrac02 = 0.2;
148+
inline constexpr float BimodalityDCAFrac05 = 0.5;
149+
inline constexpr float BimodalityDCAFrac1 = 1.00;
128150

129151
// KFParticle defaults
130-
inline constexpr int kKFParticleMassConstrainedConstruction = 2;
131-
inline constexpr int kKFParticleLegacyConstructionMethod = 3;
152+
inline constexpr int KFParticleMassConstrainedConstruction = 2;
153+
inline constexpr int KFParticleLegacyConstructionMethod = 3;
132154

133-
inline constexpr int kTrkCovEntries = 21;
134-
inline constexpr int kNumTrkCovPars = 6;
155+
inline constexpr int TrkCovEntries = 21;
156+
inline constexpr int NumTrkCovPars = 6;
135157

136-
inline constexpr int kTrkCovEntriesNoX = 15;
137-
inline constexpr int kNumTrkCovParsNoX = 5;
158+
inline constexpr int TrkCovEntriesNoX = 15;
159+
inline constexpr int NumTrkCovParsNoX = 5;
138160

139-
inline constexpr int kNumTrkComponents = 3;
161+
inline constexpr int NumTrkComponents = 3;
140162

141163
// Vertexing defaults
142-
inline constexpr float kVertexingLxyzTolerance = 1.0e-8f;
143-
inline constexpr float kInitialShift = 0.0f;
164+
inline constexpr float VertexingLxyzTolerance = 1.0e-8f;
165+
inline constexpr float InitialShift = 0.0f;
144166

145-
inline constexpr float kGJMinMagnitude = 1.e-6f;
167+
inline constexpr float GJMinMagnitude = 1.e-6f;
146168

147169
// Detector defaults
148-
inline constexpr int kPostCalibElectron = 0;
149-
inline constexpr int kPostCalibPion = 1;
150-
inline constexpr int kPostCalibKaon = 2;
151-
inline constexpr int kPostCalibProton = 3;
170+
inline constexpr int PostCalibElectron = 0;
171+
inline constexpr int PostCalibPion = 1;
172+
inline constexpr int PostCalibKaon = 2;
173+
inline constexpr int PostCalibProton = 3;
174+
175+
inline constexpr int TPCPIDCalibrationMeanSigma = 1;
176+
inline constexpr int TPCPIDCalibrationMeanSigmaStatus = 2;
177+
178+
inline constexpr int NumITSLayers = 7;
179+
180+
inline constexpr int NumMFTLayers = 10;
181+
inline constexpr float MuonAbsorberExitZ = -505.; // cm
152182

153-
inline constexpr float kMuonAbsorberExitZ = -505.; // cm
183+
inline constexpr double InvalidZnEnergy = -1.e12;
184+
inline constexpr int ZDCNeutronNTowers = 4;
154185

155-
inline constexpr double kInvalidZnEnergy = -1.e12;
156-
inline constexpr int kZDCNeutronNTowers = 4;
186+
inline constexpr float CurvatureNormalizationFactor = 2.466;
157187

158188
// Hadron defaults
159-
inline constexpr float kInitialHadronMass = 0.0f;
189+
inline constexpr float InitialHadronMass = 0.0f;
160190

161191
// Lifetimes
162-
inline constexpr float kLifetimeBPlus = 1.638e-12f; // s
163-
inline constexpr float kLifetimeB0 = 1.517e-12f; // s
192+
inline constexpr float LifetimeBPlus = 1.638e-12f; // s
193+
inline constexpr float LifetimeB0 = 1.517e-12f; // s
164194

165195
} // namespace defaults
166196

167-
} // namespace o2::aod::dqconstants
197+
} // namespace o2::dqconstants
168198

169-
#endif //PWGDQ_CORE_DQCONSTANTS_H_
199+
#endif // PWGDQ_CORE_DQCONSTANTS_H_

0 commit comments

Comments
 (0)