Linter fixes 2

Author: ekryshen

Common/TableProducer/eventSelectionServiceRun2.cxx

@@ -43,7 +43,7 @@ using BCsWithRun3Matchings = soa::Join<aod::BCs, aod::Run3MatchedToBCSparse>;
 using FullTracks = soa::Join<aod::Tracks, aod::TracksExtra>;
 using FullTracksIU = soa::Join<aod::TracksIU, aod::TracksExtra>;
 
-struct EventselectionRun2 {
+struct EventselectionRun2 { // o2-linter: disable=name/workflow-file (exception due to metadata-driven topology)
   o2::common::timestamp::TimestampConfigurables timestampConfigurables;
   o2::common::timestamp::TimestampModule timestampMod;
 
@@ -53,7 +53,7 @@ struct EventselectionRun2 {
   o2::common::eventselection::EvselConfigurables evselOpts;
   o2::common::eventselection::EventSelectionModule evselmodule;
 
-  Produces<aod::Timestamps> timestampTable; /// Table with SOR timestamps produced by the task
+  Produces<aod::Timestamps> timestampTable; // Table with SOR timestamps produced by the task
   Produces<aod::BcSels> bcsel;
   Produces<aod::EvSels> evsel;
 
@@ -102,7 +102,7 @@ struct EventselectionRun2 {
   }
 };
 
-struct EventselectionRun3 {
+struct EventselectionRun3 { // o2-linter: disable=name/workflow-file (exception due to metadata-driven topology)
   o2::common::timestamp::TimestampConfigurables timestampConfigurables;
   o2::common::timestamp::TimestampModule timestampMod;
 

Common/Tools/EventSelectionModule.h

@@ -1757,13 +1757,13 @@ class LumiModule
         double perBcRateTCE = static_cast<double>(mCounterTCE[i + 1] - mCounterTCE[i]) / nOrbits / nCollidingBCs;
         double perBcRateZNC = static_cast<double>(mCounterZNC[i + 1] - mCounterZNC[i]) / nOrbits / nCollidingBCs;
         double perBcRateZEM = static_cast<double>(mCounterZEM[i + 1] - mCounterZEM[i]) / nOrbits / nCollidingBCs;
-        constexpr float rateMin = 1.e-10;
+        const float rateMin = 1.e-10;
         double muTVX = (perBcRateTVX < 1 && perBcRateTVX > rateMin) ? -std::log(1 - perBcRateTVX) : 0;
         double muTCE = (perBcRateTCE < 1 && perBcRateTCE > rateMin) ? -std::log(1 - perBcRateTCE) : 0;
         double muZNC = (perBcRateZNC < 1 && perBcRateZNC > rateMin) ? -std::log(1 - perBcRateZNC) : 0;
         double muZEM = (perBcRateZEM < 1 && perBcRateZEM > rateMin) ? -std::log(1 - perBcRateZEM) : 0;
         LOGP(debug, "orbit={} muTVX={} muTCE={} muZNC={} muZEM={}", mOrbits[i], muTVX, muTCE, muZNC, muZEM);
-        constexpr float muMin = 1.e-10;
+        const float muMin = 1.e-10;
         mPileupCorrectionTVX.push_back(muTVX > muMin ? muTVX / (1 - std::exp(-muTVX)) : 1);
         mPileupCorrectionTCE.push_back(muTCE > muMin ? muTCE / (1 - std::exp(-muTCE)) : 1);
         mPileupCorrectionZNC.push_back(muZNC > muMin ? muZNC / (1 - std::exp(-muZNC)) : 1);

Common/Tools/timestampModule.h

@@ -109,9 +109,9 @@ class TimestampModule
         // FIXME this should not have been a problem, to be investigated
         ccdb->clearCache(timestampOpts.orbitResetPath.value.data());
 
-        constexpr int maxRunNumberUnanchored = 499999;
-        constexpr int minRunNumberUnanchored = 300000;
-        const bool isUnanchoredRun3MC = runNumber >= minRunNumberUnanchored && runNumber < maxRunNumberUnanchored;
+        const int maxRunNumberUnanchored = 499999;
+        const int minRunNumberUnanchored = 300000;
+        const bool isUnanchoredRun3MC = runNumber >= minRunNumberUnanchored && runNumber <= maxRunNumberUnanchored;
         if (timestampOpts.isRun2MC.value == 1 || isUnanchoredRun3MC) {
           // isRun2MC: bc/orbit distributions are not simulated in Run2 MC. All bcs are set to 0.
           // isUnanchoredRun3MC: assuming orbit-reset is done in the beginning of each run