[Common] Fix unused variables, parameters, values (#18638)

Author: vkucera

Common/Core/macros/testCollisionTypeHelper.C

@@ -26,5 +26,5 @@ void testCollisionTypeHelper(int runNumber = 544124)
   o2::parameters::GRPLHCIFData* grpo = ccdb.getSpecificForRun<o2::parameters::GRPLHCIFData>("GLO/Config/GRPLHCIF",
                                                                                             runNumber);
   grpo->print();
-  int collsys = o2::common::core::CollisionSystemType::getCollisionTypeFromGrp(grpo);
+  [[maybe_unused]] int collsys = o2::common::core::CollisionSystemType::getCollisionTypeFromGrp(grpo);
 }

Common/TableProducer/PID/pidTOFBase.cxx

@@ -469,7 +469,7 @@ struct tofEventTime {
         // Reset the event time
         eventTime = 0.f;
         sumOfWeights = 0.f;
-        weight = 0.f;
+        // weight = 0.f; // FIXME: unused
         // Remove the bias on TOF ev. time
         if constexpr (removeTOFEvTimeBias) {
           evTimeTOF.removeBias<TrksEvTime::iterator, filterForTOFEventTime>(trk, nGoodTracksForTOF, t0TOF[0], t0TOF[1], 2);

Common/TableProducer/PID/pidTOFMerge.cxx

@@ -435,7 +435,7 @@ struct tofEventTime {
           // Reset the event time
           eventTime = 0.f;
           sumOfWeights = 0.f;
-          weight = 0.f;
+          // weight = 0.f; // FIXME: unused
           // Remove the bias on TOF ev. time
           if constexpr (kRemoveTOFEvTimeBias) {
             evTimeMakerTOF.removeBias<Run3TrksWtof::iterator, filterForTOFEventTime>(trk, nGoodTracksForTOF, t0TOF[0], t0TOF[1], 2);

Common/TableProducer/caloClusterProducer.cxx

@@ -1116,9 +1116,9 @@ struct CaloClusterProducer {
         if (cpvdist != 99.) {           // was evaluated
           cpvdist = std::sqrt(cpvdist); // was squared
         }
-        if (trackdist != 99.) {             // was evaluated
-          trackdist = std::sqrt(trackdist); // was squared
-        }
+        // if (trackdist != 99.) {             // was evaluated
+        //   trackdist = std::sqrt(trackdist); // was squared // FIXME: unused
+        // }
 
         float lambdaShort = 0., lambdaLong = 0.;
         clu.getElipsAxis(lambdaShort, lambdaLong);
@@ -1544,9 +1544,9 @@ struct CaloClusterProducer {
         if (cpvdist != 99.) {           // was evaluated
           cpvdist = std::sqrt(cpvdist); // was squared
         }
-        if (trackdist != 99.) {             // was evaluated
-          trackdist = std::sqrt(trackdist); // was squared
-        }
+        // if (trackdist != 99.) {             // was evaluated
+        //   trackdist = std::sqrt(trackdist); // was squared // FIXME: unused
+        // }
 
         float lambdaShort = 0., lambdaLong = 0.;
         clu.getElipsAxis(lambdaShort, lambdaLong);

Common/TableProducer/match-mft-ft0.cxx

@@ -367,7 +367,7 @@ struct matchmftft0 {
 
         auto ft0s = bc.ft0s();
         i = 0; // reinitialise
-        D = 0.0;
+        // D = 0.0; // FIXME: unused
         minD = 999.9;
         for (auto const& ft0 : ft0s) {
           // printf("---------ft0.bcId %d\n", ft0.bcId());

Common/Tools/Multiplicity/macros/runCalibration.C

@@ -40,7 +40,7 @@ void runCalibration(const TString& lInputFileName = "results/AR_544122_glauberNB
 
   TH1F* hData = dynamic_cast<TH1F*>(file->Get("hV0MUltraFine"));
   TH1F* hGlauberParameters = dynamic_cast<TH1F*>(file->Get("hGlauberParameters"));
-  TH1F* hGlauberFitRange = dynamic_cast<TH1F*>(file->Get("hGlauberFitRange"));
+  [[maybe_unused]] TH1F* hGlauberFitRange = dynamic_cast<TH1F*>(file->Get("hGlauberFitRange"));
   hData->SetName("hData");
   TH1F* hStitched = dynamic_cast<TH1F*>(hData->Clone("hStitched"));
   TH1F* hFit = dynamic_cast<TH1F*>(file->Get("hGlauber"));

Common/Tools/Multiplicity/macros/runGlauberFit.C

@@ -357,8 +357,8 @@ int runGlauberFit(const TString& lInputFileName = "AnalysisResultsLHC24ar.root",
   c1->cd(1);
   TLatex* lat = new TLatex();
   lat->SetNDC();
-  Float_t lPosText = 0.76;
-  Float_t lYShift = 0.25;
+  // Float_t lPosText = 0.76; // FIXME: unused
+  // Float_t lYShift = 0.25; // FIXME: unused
   lat->SetTextSize(0.042);
 
   // save the glauber parameters explicitly

Common/Tools/Multiplicity/macros/saveCorrelation.C

@@ -59,6 +59,7 @@ void saveCorrelation(const TString& filename = "gmc-PbPb-snn68.21-md0.40-nd-1.0-
 
   // 2D correlation plot necessary for Glauber + NBD fitting
   // The provided range should be enough for Pb-Pb
+  // NOLINTNEXTLINE(clang-analyzer-deadcode.DeadStores,clang-diagnostic-unused-variable)
   TH2D* hNpNc = new TH2D("hNpNc", "", 500, -0.5, 499.5, 2500, -0.5, 2499.5);
 
   // let's draw this on screen for inspection