Fix unused variables, parameters, values

Fixes errors from the following Clang-Tidy categories:

- `clang-analyzer-deadcode.DeadStores`
- `clang-diagnostic-unused-parameter`
- `clang-diagnostic-unused-variable`

Most errors are fixed temporarily by commenting out the unused bits and by adding a `FIXME: unused` comment.

The final fix is to either remove the unused bits or to fix the bugs which has to be done by someone who knows the intended behaviour.

Author: vkucera

EventFiltering/macros/checkBCRange.C

@@ -131,7 +131,7 @@ void checkBCRange(const char* filename, const char* rangeFileName)
     }
   }
 
-  TList* directoryList = inputFile.GetListOfKeys();
+  // TList* directoryList = inputFile.GetListOfKeys(); // FIXME: unused
   std::vector<InteractionRecord> bcids;
   for (auto key : *inputFile.GetListOfKeys()) {
     TTree* treeDecision = dynamic_cast<TTree*>(inputFile.Get(Form("%s/O2cefpdecision", key->GetName())));

EventFiltering/macros/checkBCrangesSkimming.C

@@ -46,8 +46,8 @@ struct bcTuple {
 };
 
 struct selectedFrames : public IRFrame {
-  selectedFrames(ULong64_t bcAO2D, ULong64_t bcEvSel, const IRFrame& frame) : IRFrame(frame), bcAO2D(bcAO2D), bcEvSel(bcEvSel), triMask{0, 0}, selMask{0, 0} {}
-  selectedFrames(ULong64_t bcAO2D, ULong64_t bcEvSel, ULong64_t triMask[2], ULong64_t selMask[2], const IRFrame& frame) : IRFrame(frame), bcAO2D(bcAO2D), bcEvSel(bcEvSel), triMask{triMask[0], triMask[1]}, selMask{selMask[0], selMask[1]} {}
+  selectedFrames(ULong64_t bcAO2D, ULong64_t bcEvSel, const IRFrame& frame) : IRFrame(frame), triMask{0, 0}, selMask{0, 0}, bcAO2D(bcAO2D), bcEvSel(bcEvSel) {}
+  selectedFrames(ULong64_t bcAO2D, ULong64_t bcEvSel, ULong64_t triMask[2], ULong64_t selMask[2], const IRFrame& frame) : IRFrame(frame), triMask{triMask[0], triMask[1]}, selMask{selMask[0], selMask[1]}, bcAO2D(bcAO2D), bcEvSel(bcEvSel) {}
   ULong64_t triMask[2]{0ull}, selMask[2]{0ull}, bcAO2D, bcEvSel;
   int numSameTriggerInNearbyBCs = 0; // related to bcDiffTolerance
   bool isSingle() { return numSameTriggerInNearbyBCs == 0; }
@@ -447,7 +447,7 @@ void checkBCrangesSkimming(std::string AnaFileName = "AnalysisResults.root", std
     }
 
     // Check BC differences
-    int npair{0}, npairedBCAO2D{0}, npairedBCEvSel{0}, ncloseskimmed{0}, maxdeltaBCAO2D{0}, maxdeltaBCEvSel{0};
+    int npair{0}, npairedBCAO2D{0}, npairedBCEvSel{0}, ncloseskimmed{0}; //, maxdeltaBCAO2D{0}, maxdeltaBCEvSel{0}; // FIXME: unused
     int firstTrg = 0;
     for (int i = 0; i < originalFrames.size(); i++) {
       auto& frame = originalFrames[i];

EventFiltering/macros/selectivityPlot.C

@@ -78,8 +78,8 @@ void selectivityPlot(int runNumber = 550781, const TString& inputfile = "Analysi
   line->Draw();
   TArrow* arrow = new TArrow(mFiltered->GetXaxis()->GetXmax(), 0.0005, mFiltered->GetXaxis()->GetXmax() + 1, 0.0005, 0.01, "<|");
 
-  Int_t ci;      // for color index setting
-  TColor* color; // for color definition with alpha
+  Int_t ci; // for color index setting
+  // TColor* color; // for color definition with alpha // FIXME: unused
   ci = TColor::GetColor("#0000ff");
   arrow->SetFillColor(ci);
   arrow->SetFillStyle(1001);

EventFiltering/macros/uploadOTSobjects.C

@@ -137,7 +137,7 @@ void uploadOTSobjects(std::string inputList, const std::string& passName, bool u
             endTS = (orbitResetTimestamp + static_cast<int64_t>(bcEnd * o2::constants::lhc::LHCBunchSpacingNS * 1e-3)) / 1000 + 1;
             break;
           }
-          bcEnd = nextHelper.bcAOD > nextHelper.bcEvSel ? nextHelper.bcAOD : nextHelper.bcEvSel;
+          // bcEnd = nextHelper.bcAOD > nextHelper.bcEvSel ? nextHelper.bcAOD : nextHelper.bcEvSel; // FIXME: unused
           endIndex++;
         }
         std::cout << ">>> Chunk " << helperIndex << " - " << helperIndex + chunk.size() << " : " << startTS << " - " << endTS << " \t" << (endTS - startTS) * 1.e-3 << std::endl;