Skip to content

Commit 5e83339

Browse files
joonsukbaeclaude
joonsukbae
and
claude
committed
[PWGJE] Replace magic number 10. with named variable simPtRef in pTHat calculation
Replace hardcoded 10. with simPtRef variable in trackEfficiency and jetSpectraCharged for readability. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 7409d38 commit 5e83339

File tree

2 files changed

+21
-20
lines changed

2 files changed

+21
-20
lines changed

‎PWGJE/Tasks/jetSpectraCharged.cxx‎

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ struct JetSpectraCharged {
8383

8484
std::vector<int> eventSelectionBits;
8585
int trackSelection = -1;
86+
float simPtRef = 10.;
8687

8788
bool doSumw2 = false;
8889

@@ -715,7 +716,7 @@ struct JetSpectraCharged {
715716

716717
registry.fill(HIST("h_collisions_zvertex"), collision.posZ(), eventWeight);
717718

718-
float pTHat = 10. / (std::pow(eventWeight, 1.0 / pTHatExponent));
719+
float pTHat = simPtRef / (std::pow(eventWeight, 1.0 / pTHatExponent));
719720
registry.fill(HIST("h_coll_phat"), pTHat);
720721
registry.fill(HIST("h_coll_phat_weighted"), pTHat, eventWeight);
721722
}
@@ -744,7 +745,7 @@ struct JetSpectraCharged {
744745

745746
registry.fill(HIST("h_mccollisions_zvertex"), mccollision.posZ(), eventWeight);
746747

747-
float pTHat = 10. / (std::pow(eventWeight, 1.0 / pTHatExponent));
748+
float pTHat = simPtRef / (std::pow(eventWeight, 1.0 / pTHatExponent));
748749
registry.fill(HIST("h_mccoll_phat"), pTHat);
749750
registry.fill(HIST("h_mccoll_phat_weighted"), pTHat, eventWeight);
750751
}
@@ -853,7 +854,7 @@ struct JetSpectraCharged {
853854
if (!applyCollisionCuts(collision, fillHistograms, isWeighted, eventWeight)) {
854855
return;
855856
}
856-
float pTHat = collision.has_mcCollision() && collision.mcCollision().ptHard() < 999.0f ? collision.mcCollision().ptHard() : 10. / (std::pow(eventWeight, 1.0 / pTHatExponent));
857+
float pTHat = collision.has_mcCollision() && collision.mcCollision().ptHard() < 999.0f ? collision.mcCollision().ptHard() : simPtRef / (std::pow(eventWeight, 1.0 / pTHatExponent));
857858
float centrality = -1.0;
858859
checkCentFT0M ? centrality = collision.centFT0M() : centrality = collision.centFT0C();
859860

@@ -880,7 +881,7 @@ struct JetSpectraCharged {
880881
if (!applyCollisionCuts(collision, fillHistograms, isWeighted, eventWeight)) {
881882
return;
882883
}
883-
float pTHat = collision.has_mcCollision() && collision.mcCollision().ptHard() < 999.0f ? collision.mcCollision().ptHard() : 10. / (std::pow(eventWeight, 1.0 / pTHatExponent));
884+
float pTHat = collision.has_mcCollision() && collision.mcCollision().ptHard() < 999.0f ? collision.mcCollision().ptHard() : simPtRef / (std::pow(eventWeight, 1.0 / pTHatExponent));
884885
float centrality = -1.0;
885886
checkCentFT0M ? centrality = collision.centFT0M() : centrality = collision.centFT0C();
886887

@@ -1123,7 +1124,7 @@ struct JetSpectraCharged {
11231124
if (!applyMCCollisionCuts(mccollision, collisions, fillHistograms, isWeighted, eventWeight)) {
11241125
return;
11251126
}
1126-
float pTHat = mccollision.ptHard() < 999.0f ? mccollision.ptHard() : 10. / (std::pow(eventWeight, 1.0 / pTHatExponent));
1127+
float pTHat = mccollision.ptHard() < 999.0f ? mccollision.ptHard() : simPtRef / (std::pow(eventWeight, 1.0 / pTHatExponent));
11271128
for (auto const& jet : jets) {
11281129
if (!jetfindingutilities::isInEtaAcceptance(jet, jetEtaMin, jetEtaMax, trackEtaMin, trackEtaMax)) {
11291130
continue;
@@ -1155,7 +1156,7 @@ struct JetSpectraCharged {
11551156
if (!applyMCCollisionCuts(mccollision, collisions, fillHistograms, isWeighted, eventWeight)) {
11561157
return;
11571158
}
1158-
float pTHat = mccollision.ptHard() < 999.0f ? mccollision.ptHard() : 10. / (std::pow(eventWeight, 1.0 / pTHatExponent));
1159+
float pTHat = mccollision.ptHard() < 999.0f ? mccollision.ptHard() : simPtRef / (std::pow(eventWeight, 1.0 / pTHatExponent));
11591160
registry.fill(HIST("h_mccollisions_rho"), mccollision.rho(), eventWeight);
11601161

11611162
for (auto const& jet : jets) {
@@ -1246,7 +1247,7 @@ struct JetSpectraCharged {
12461247
if (!applyCollisionCuts(collision, fillHistograms, isWeighted, eventWeight)) {
12471248
return;
12481249
}
1249-
float pTHat = collision.has_mcCollision() && collision.mcCollision().ptHard() < 999.0f ? collision.mcCollision().ptHard() : 10. / (std::pow(eventWeight, 1.0 / pTHatExponent));
1250+
float pTHat = collision.has_mcCollision() && collision.mcCollision().ptHard() < 999.0f ? collision.mcCollision().ptHard() : simPtRef / (std::pow(eventWeight, 1.0 / pTHatExponent));
12501251
for (const auto& mcdjet : mcdjets) {
12511252
if (!isAcceptedJet<aod::JetTracks>(mcdjet)) {
12521253
continue;
@@ -1289,7 +1290,7 @@ struct JetSpectraCharged {
12891290
if (!applyCollisionCuts(collision, fillHistograms, isWeighted, eventWeight)) {
12901291
return;
12911292
}
1292-
float pTHat = collision.has_mcCollision() && collision.mcCollision().ptHard() < 999.0f ? collision.mcCollision().ptHard() : 10. / (std::pow(eventWeight, 1.0 / pTHatExponent));
1293+
float pTHat = collision.has_mcCollision() && collision.mcCollision().ptHard() < 999.0f ? collision.mcCollision().ptHard() : simPtRef / (std::pow(eventWeight, 1.0 / pTHatExponent));
12931294

12941295
double mcrho = collision.has_mcCollision() ? collision.mcCollision_as<JetBkgRhoMcCollisions>().rho() : -1;
12951296

‎PWGJE/Tasks/trackEfficiency.cxx‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@ struct TrackEfficiency {
476476
}
477477
registry.fill(HIST("hMcCollCutsCounts"), 5.5); // at least one of the reconstructed collisions associated with this mcCollision is selected with regard to centrality
478478

479-
float pTHat = mcCollision.ptHard() < 999.0f ? mcCollision.ptHard() : 10. / (std::pow(mcCollision.weight(), 1.0 / pTHatExponent));
479+
float pTHat = mcCollision.ptHard() < 999.0f ? mcCollision.ptHard() : simPtRef / (std::pow(mcCollision.weight(), 1.0 / pTHatExponent));
480480
if (pTHat < ptHatMin || pTHat > ptHatMax) { // only allows mcCollisions with weight in between min and max
481481
return;
482482
}
@@ -819,7 +819,7 @@ struct TrackEfficiency {
819819
return;
820820
}
821821

822-
float pTHat = collision.mcCollision().ptHard() < 999.0f ? collision.mcCollision().ptHard() : 10. / (std::pow(collision.mcCollision().weight(), 1.0 / pTHatExponent));
822+
float pTHat = collision.mcCollision().ptHard() < 999.0f ? collision.mcCollision().ptHard() : simPtRef / (std::pow(collision.mcCollision().weight(), 1.0 / pTHatExponent));
823823
if (pTHat < ptHatMin || pTHat > ptHatMax) { // only allows mcCollisions with weight in between min and max
824824
return;
825825
}
@@ -848,7 +848,7 @@ struct TrackEfficiency {
848848
return;
849849
}
850850

851-
float pTHat = collision.mcCollision().ptHard() < 999.0f ? collision.mcCollision().ptHard() : 10. / (std::pow(eventWeight, 1.0 / pTHatExponent));
851+
float pTHat = collision.mcCollision().ptHard() < 999.0f ? collision.mcCollision().ptHard() : simPtRef / (std::pow(eventWeight, 1.0 / pTHatExponent));
852852
if (pTHat < ptHatMin || pTHat > ptHatMax) { // only allows mcCollisions with weight in between min and max
853853
return;
854854
}
@@ -873,7 +873,7 @@ struct TrackEfficiency {
873873
return;
874874
}
875875

876-
float pTHat = mcCollision.ptHard() < 999.0f ? mcCollision.ptHard() : 10. / (std::pow(mcCollision.weight(), 1.0 / pTHatExponent));
876+
float pTHat = mcCollision.ptHard() < 999.0f ? mcCollision.ptHard() : simPtRef / (std::pow(mcCollision.weight(), 1.0 / pTHatExponent));
877877
if (pTHat < ptHatMin || pTHat > ptHatMax) { // only allows mcCollisions with weight in between min and max
878878
return;
879879
}
@@ -936,7 +936,7 @@ struct TrackEfficiency {
936936
return;
937937
}
938938

939-
float pTHat = mcCollision.ptHard() < 999.0f ? mcCollision.ptHard() : 10. / (std::pow(eventWeight, 1.0 / pTHatExponent));
939+
float pTHat = mcCollision.ptHard() < 999.0f ? mcCollision.ptHard() : simPtRef / (std::pow(eventWeight, 1.0 / pTHatExponent));
940940
if (pTHat < ptHatMin || pTHat > ptHatMax) { // only allows mcCollisions with weight in between min and max
941941
return;
942942
}
@@ -1030,7 +1030,7 @@ struct TrackEfficiency {
10301030
registry.fill(HIST("h_collisions"), 3.5);
10311031
registry.fill(HIST("h2_centrality_collisions"), centrality, 3.5);
10321032

1033-
float pTHat = collision.mcCollision().ptHard() < 999.0f ? collision.mcCollision().ptHard() : 10. / (std::pow(collision.mcCollision().weight(), 1.0 / pTHatExponent));
1033+
float pTHat = collision.mcCollision().ptHard() < 999.0f ? collision.mcCollision().ptHard() : simPtRef / (std::pow(collision.mcCollision().weight(), 1.0 / pTHatExponent));
10341034
if (pTHat < ptHatMin || pTHat > ptHatMax) { // only allows mcCollisions with weight in between min and max
10351035
return;
10361036
}
@@ -1067,7 +1067,7 @@ struct TrackEfficiency {
10671067
registry.fill(HIST("h_collisions"), 3.5);
10681068
registry.fill(HIST("h_collisions_weighted"), 3.5, eventWeight);
10691069

1070-
float pTHat = collision.mcCollision().ptHard() < 999.0f ? collision.mcCollision().ptHard() : 10. / (std::pow(eventWeight, 1.0 / pTHatExponent));
1070+
float pTHat = collision.mcCollision().ptHard() < 999.0f ? collision.mcCollision().ptHard() : simPtRef / (std::pow(eventWeight, 1.0 / pTHatExponent));
10711071
if (pTHat < ptHatMin || pTHat > ptHatMax) { // only allows mcCollisions with weight in between min and max
10721072
return;
10731073
}
@@ -1082,8 +1082,8 @@ struct TrackEfficiency {
10821082
// float centrality = checkCentFT0M ? mcCollision.centFT0M() : mcCollision.centFT0C(); mcCollision.centFT0C() isn't filled at the moment; can be added back when it is
10831083

10841084
float eventWeight = mcCollision.weight();
1085-
float pTHat = mcCollision.ptHard() < 999.0f ? mcCollision.ptHard() : 10. / (std::pow(eventWeight, 1.0 / pTHatExponent));
1086-
registry.fill(HIST("h2_mccollision_pthardfromweight_pthardfromhepmcxsection"), 10. / (std::pow(eventWeight, 1.0 / pTHatExponent)), mcCollision.ptHard());
1085+
float pTHat = mcCollision.ptHard() < 999.0f ? mcCollision.ptHard() : simPtRef / (std::pow(eventWeight, 1.0 / pTHatExponent));
1086+
registry.fill(HIST("h2_mccollision_pthardfromweight_pthardfromhepmcxsection"), simPtRef / (std::pow(eventWeight, 1.0 / pTHatExponent)), mcCollision.ptHard());
10871087

10881088
float centrality = -1;
10891089
bool hasSel8Coll = false;
@@ -1154,9 +1154,9 @@ struct TrackEfficiency {
11541154
// float centrality = checkCentFT0M ? mcCollision.centFT0M() : mcCollision.centFT0C(); mcCollision.centFT0C() isn't filled at the moment; can be added back when it is
11551155

11561156
float eventWeight = mcCollision.weight();
1157-
float pTHat = mcCollision.ptHard() < 999.0f ? mcCollision.ptHard() : 10. / (std::pow(eventWeight, 1.0 / pTHatExponent));
1158-
registry.fill(HIST("h2_mccollision_pthardfromweight_pthardfromhepmcxsection"), 10. / (std::pow(eventWeight, 1.0 / pTHatExponent)), mcCollision.ptHard());
1159-
registry.fill(HIST("h2_mccollision_pthardfromweight_pthardfromhepmcxsection_weighted"), 10. / (std::pow(eventWeight, 1.0 / pTHatExponent)), mcCollision.ptHard(), eventWeight);
1157+
float pTHat = mcCollision.ptHard() < 999.0f ? mcCollision.ptHard() : simPtRef / (std::pow(eventWeight, 1.0 / pTHatExponent));
1158+
registry.fill(HIST("h2_mccollision_pthardfromweight_pthardfromhepmcxsection"), simPtRef / (std::pow(eventWeight, 1.0 / pTHatExponent)), mcCollision.ptHard());
1159+
registry.fill(HIST("h2_mccollision_pthardfromweight_pthardfromhepmcxsection_weighted"), simPtRef / (std::pow(eventWeight, 1.0 / pTHatExponent)), mcCollision.ptHard(), eventWeight);
11601160

11611161
float centrality = -1;
11621162
bool hasSel8Coll = false;

0 commit comments

Comments
 (0)