Skip to content

Commit 5c6d097

Browse files
committed
Apply review comments, avoid Bimodality constants
1 parent 906bec0 commit 5c6d097

2 files changed

Lines changed: 102 additions & 111 deletions

File tree

‎PWGDQ/Core/DQConstants.h‎

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
#ifndef PWGDQ_CORE_DQCONSTANTS_H_
1717
#define PWGDQ_CORE_DQCONSTANTS_H_
1818

19+
#include <array>
1920
#include <cstdint>
2021

2122
namespace o2::dqconstants
@@ -44,7 +45,7 @@ inline constexpr float InvalidDCA = 998.0f;
4445
inline constexpr float InvalidStdDev = -1.0;
4546

4647
// Checks
47-
inline constexpr auto IsCoordinateInvalid = [](float value) constexpr -> bool {
48+
inline constexpr auto IsCoordinateValid = [](float value) constexpr -> bool {
4849
return value < 0.f;
4950
};
5051

@@ -144,13 +145,10 @@ inline constexpr int BimodalMinDataSize = 3;
144145
inline constexpr float BimodalityInvalidBinWidth = -1.0;
145146
inline constexpr float BimodalityBinWidth = 0.005;
146147

147-
inline constexpr float BimodalityDCAFrac001 = 0.01;
148-
inline constexpr float BimodalityDCAFrac002 = 0.02;
149-
inline constexpr float BimodalityDCAFrac005 = 0.05;
150-
inline constexpr float BimodalityDCAFrac01 = 0.1;
151-
inline constexpr float BimodalityDCAFrac02 = 0.2;
152-
inline constexpr float BimodalityDCAFrac05 = 0.5;
153-
inline constexpr float BimodalityDCAFrac1 = 1.00;
148+
// DCA thresholds in cm: 100 µm, 200 µm, 500 µm, 1 mm, 2 mm, 5 mm, 10 mm
149+
inline constexpr std::array<float, 7> BimodalityDCAThresholdsCm{
150+
0.01f, 0.02f, 0.05f, 0.1f,
151+
0.2f, 0.5f, 1.0f};
154152

155153
// KFParticle defaults
156154
inline constexpr int KFParticleMassConstrainedConstruction = 2;

0 commit comments

Comments
 (0)