Skip to content

Commit 08136eb

Browse files
author
Stefanie Mrozinski
committed
rename configurables to fill
1 parent 7e7a1f8 commit 08136eb

4 files changed

Lines changed: 19 additions & 19 deletions

File tree

‎PWGEM/PhotonMeson/DataModel/gammaTables.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -705,7 +705,7 @@ DECLARE_SOA_TABLE(PCMMixLegs, "AOD", "PCMMIXLEG", //!
705705
track::HasITS<track::DetectorMap>, track::HasTPC<track::DetectorMap>, track::HasTRD<track::DetectorMap>, track::HasTOF<track::DetectorMap>);
706706
using PCMMixLeg = PCMMixLegs::iterator;
707707

708-
// free electron legs of builder run 1 (storeFreeLegs): tracks that pass the leg cuts and are the leg of no stored photon; the
708+
// free electron legs of builder run 1 (fillFreeLegs): tracks that pass the leg cuts and are the leg of no stored photon; the
709709
// parameters as the V0 fit would use them (TPC-only legs moved to their own collision). The mixer pools them with the photons
710710
// (cfgPoolFreeLegs), so that run 2 can pair them in the same and the mixed event alike.
711711
namespace pcmfreeleg

‎PWGEM/PhotonMeson/TableProducer/createEMEventPhoton.cxx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ struct CreateEMEventPhoton {
6868
Produces<o2::aod::EMSWTriggerBits> emswtbit;
6969
Produces<o2::aod::EMEventNormInfos_001> event_norm_info;
7070
Produces<o2::aod::EMEventsWeight> eventWeights;
71-
Produces<o2::aod::EMEventsXY> eventXY; // only with storeVertex
72-
Produces<o2::aod::EMEventsCov> eventCov; // only with storeVertex
71+
Produces<o2::aod::EMEventsXY> eventXY; // filled only with fillVertex
72+
Produces<o2::aod::EMEventsCov> eventCov; // filled only with fillVertex
7373

7474
enum class EMEventType : int {
7575
kEvent = 0,
@@ -78,7 +78,7 @@ struct CreateEMEventPhoton {
7878
kEvent_JJ = 3,
7979
};
8080

81-
Configurable<bool> storeVertex{"storeVertex", false, "write EMEventsXY and EMEventsCov (primary vertex x, y, covariance, chi2), joinable to PMEvents: needed by the co-reconstructed mixed event on derived data (photon-mixed-event-producer processDerived)"};
81+
Configurable<bool> fillVertex{"fillVertex", false, "fill EMEventsXY and EMEventsCov (primary vertex x, y, covariance, chi2; the tables are written in any case, empty if false), joinable to PMEvents: needed by the co-reconstructed mixed event on derived data (photon-mixed-event-producer processDerived)"};
8282
Configurable<bool> needEMCTrigger{"needEMCTrigger", false, "flag to only save events which have kTVXinEMC trigger bit. To reduce PbPb derived data size"};
8383
Configurable<bool> needPHSTrigger{"needPHSTrigger", false, "flag to only save events which have kTVXinPHOS trigger bit. To reduce PbPb derived data size"};
8484
Configurable<bool> enableJJHistograms{"enableJJHistograms", false, "flag to fill JJ QA histograms for outlier rejection"};
@@ -153,7 +153,7 @@ struct CreateEMEventPhoton {
153153
collision.numContrib(), collision.trackOccupancyInTimeRange(), collision.ft0cOccupancyInTimeRange());
154154
eventalias(collision.alias_raw());
155155

156-
if (storeVertex) {
156+
if (fillVertex) {
157157
eventXY(collision.posX(), collision.posY());
158158
eventCov(collision.covXX(), collision.covXY(), collision.covXZ(), collision.covYY(), collision.covYZ(), collision.covZZ(), collision.chi2());
159159
}

‎PWGEM/PhotonMeson/TableProducer/photonMixedEventProducer.cxx‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
// per event one same-event artificial event (the complete event) and cfgOverlay mixed artificial events
1616
// (the complete event + one complete partner event of its pool, translated to the
1717
/// current vertex), written as PCMMixCollisions / PCMMixLegs for photon-conversion-builder-mixed. Needs builder run 1 with
18-
/// storeLegCov = true and storeFreeLegs = true.
18+
/// fillLegCov = true and fillFreeLegs = true.
1919
/// \author Stefanie Mrozinski
2020

2121
#include "PWGEM/PhotonMeson/DataModel/EventTables.h"
@@ -135,7 +135,7 @@ struct PhotonMixedEventProducer {
135135
Configurable<bool> cfgPhotonWeighted{"cfgPhotonWeighted", true, "partner events drawn with probability proportional to their photon number (each pooled photon equally likely, still N distinct events); false: events equally likely"};
136136
Configurable<int> cfgInject{"cfgInject", 0, "injection mixed event: instead of N photons from N partner events, K mixed artificial events per event, each = the COMPLETE current event (its photons and, with cfgPoolFreeLegs, its free legs) + ONE photon of a distinct partner event (translated with cfgAlignToVertex). K = cfgInject, -1: K = N (mixed pairs = 2 x same-event pairs), -2: K = N/2 rounded up (mixed pairs = same-event pairs, half the CPU); the pool needs K partner events. Run 2 with mixed_group.skipSameSourceCrossed: the current event's pairings stay as run 1 decided them, only the injected legs form new candidates (also with the free legs, which the N-photon mixed event cannot offer)"};
137137
Configurable<int> cfgOverlay{"cfgOverlay", 1, "two-event leg overlay: K mixed artificial events per event, each = the COMPLETE current event + the COMPLETE partner event k (all its photons and, with cfgPoolFreeLegs, all its free legs, translated with cfgAlignToVertex). Every leg configuration of the same event exists across the two events, incl. true pairings that failed a run-1 cut. Run 2 with mixed_group.skipSameSourceCrossed: pairings inside one source event stay as run 1 decided them, only cross-event pairings are new. 0 = off (not with cfgInject)"};
138-
Configurable<bool> cfgPoolFreeLegs{"cfgPoolFreeLegs", true, "pool the free legs of run 1 (PCMFreeLegs, builder storeFreeLegs) with the photons: the same artificial event gets all M free legs of the event, the mixed one M free legs drawn from the N partner events, so that run 2 pairs free legs identically in both"};
138+
Configurable<bool> cfgPoolFreeLegs{"cfgPoolFreeLegs", true, "pool the free legs of run 1 (PCMFreeLegs, builder fillFreeLegs) with the photons: the same artificial event gets all M free legs of the event, the mixed one M free legs drawn from the N partner events, so that run 2 pairs free legs identically in both"};
139139

140140
HistogramRegistry registry{"registry", {}, OutputObjHandlingPolicy::AnalysisObject, false, false};
141141

@@ -452,10 +452,10 @@ struct PhotonMixedEventProducer {
452452
aod::PCMFreeLegs const* freeLegs, TTracks const* tracks, TMCParticles const* mcParticles)
453453
{
454454
if (legs.size() != 2 * photons.size() || legsCov.size() != legs.size()) {
455-
LOG(fatal) << "V0LegsCov (" << legsCov.size() << ") / V0Legs (" << legs.size() << ") / V0PhotonsKF (" << photons.size() << ") do not match: run builder run 1 with storeLegCov = true";
455+
LOG(fatal) << "V0LegsCov (" << legsCov.size() << ") / V0Legs (" << legs.size() << ") / V0PhotonsKF (" << photons.size() << ") do not match: run builder run 1 with fillLegCov = true";
456456
}
457457
if (cfgPoolFreeLegs && (freeLegs == nullptr || (freeLegs->size() == 0 && photons.size() > 0))) {
458-
LOG(fatal) << "cfgPoolFreeLegs: PCMFreeLegs is empty, run builder run 1 with storeFreeLegs = true";
458+
LOG(fatal) << "cfgPoolFreeLegs: PCMFreeLegs is empty, run builder run 1 with fillFreeLegs = true";
459459
}
460460
std::unordered_map<int, std::vector<int64_t>> photonsOfCollision, freeLegsOfCollision;
461461
for (const auto& photon : photons) {
@@ -767,7 +767,7 @@ struct PhotonMixedEventProducer {
767767
}
768768
PROCESS_SWITCH(PhotonMixedEventProducer, processMC, "MC, AO2D input (leg truth into PCMMixLegs)", false);
769769

770-
// derived data (EM skim with V0LegsCov and, from create-emevent-photon storeVertex, EMEventsXY + EMEventsCov)
770+
// derived data (EM skim with V0LegsCov and, from create-emevent-photon fillVertex, EMEventsXY + EMEventsCov)
771771
void processDerived(MyEvents const& collisions, MyPhotonsDerived const& photons, aod::V0Legs const& legs, aod::V0LegsCov const& legsCov)
772772
{
773773
runMixer<false, true>(collisions, photons, legs, legsCov, nullptr, static_cast<aod::TracksIU const*>(nullptr), static_cast<aod::EMMCParticles const*>(nullptr));

‎PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.h‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -319,9 +319,9 @@ struct PhotonConversionBuilder {
319319
Configurable<int> modeTrackPropagation{"modeTrackPropagation", 0, "0: use real track propagation, including material, 1: use fast approximation using only geometry, 2: Use real track propagation and make comparison to fast propagation (only for debugging and testing)"};
320320
Configurable<float> propV0LegsRadius{"propV0LegsRadius", 60.f, "Radius to which the V0 legs are propagated to calculate psipair and phiV"};
321321
o2::framework::Configurable<bool> useSideBasedCorrection{"useSideBasedCorrection", false, "when moving TPC-only tracks, use TPC side flags (with legacy fallback) instead of tgl sign"};
322-
Configurable<bool> storeLegCov{"storeLegCov", false, "write V0LegsCov: the leg track parameters and covariance given to the V0 fit (TPC-only legs moved to the collision), one row per V0Legs row"};
323-
Configurable<bool> storeFreeLegIds{"storeFreeLegIds", false, "write PCMFreeLegIds: the free legs (as for storeFreeLegs) as AO2D (collision, track) indices only, for the mixer on linked derived data (the leg parameters are read from the parent AO2D); only selected collisions"};
324-
Configurable<bool> storeFreeLegs{"storeFreeLegs", false, "write PCMFreeLegs: tracks that pass the leg cuts (as the finder takes them) and are the leg of no stored photon, with the parameters the V0 fit would use (TPC-only legs moved to their own collision); pooled by the mixer with cfgPoolFreeLegs"};
322+
Configurable<bool> fillLegCov{"fillLegCov", false, "fill V0LegsCov (the table is written in any case, empty if false): the leg track parameters and covariance given to the V0 fit (TPC-only legs moved to the collision), one row per V0Legs row"};
323+
Configurable<bool> fillFreeLegIds{"fillFreeLegIds", false, "fill PCMFreeLegIds (the table is written in any case, empty if false): the free legs (as for fillFreeLegs) as AO2D (collision, track) indices only, for the mixer on linked derived data (the leg parameters are read from the parent AO2D); only selected collisions"};
324+
Configurable<bool> fillFreeLegs{"fillFreeLegs", false, "fill PCMFreeLegs (the table is written in any case, empty if false): tracks that pass the leg cuts (as the finder takes them) and are the leg of no stored photon, with the parameters the V0 fit would use (TPC-only legs moved to their own collision); pooled by the mixer with cfgPoolFreeLegs"};
325325

326326
// deduplication settings
327327
struct : ConfigurableGroup {
@@ -492,7 +492,7 @@ struct PhotonConversionBuilder {
492492
"registry",
493493
{
494494
{"hCollisionCounter", "hCollisionCounter", {HistType::kTH1F, {{1, 0.5f, 1.5f}}}},
495-
{"hNFreeLegs", "free legs written per DF (storeFreeLegs);legs;DFs", {HistType::kTH1F, {{200, 0.f, 20000.f}}}},
495+
{"hNFreeLegs", "free legs filled per DF (fillFreeLegs);legs;DFs", {HistType::kTH1F, {{200, 0.f, 20000.f}}}},
496496
{"V0/hAP", "Armenteros Podolanski;#alpha;q_{T} (GeV/c)", {HistType::kTH2F, {{200, -1.0f, 1.0f}, {250, 0, 0.25}}}},
497497
{"V0/hConversionPointXY", "conversion point in XY;X (cm);Y (cm)", {HistType::kTH2F, {{400, -100.0f, 100.0f}, {400, -100.f, 100.f}}}},
498498
{"V0/hConversionPointRZ", "conversion point in RZ;Z (cm);R_{xy} (cm)", {HistType::kTH2F, {{200, -100.0f, 100.0f}, {200, 0.f, 100.f}}}},
@@ -982,7 +982,7 @@ struct PhotonConversionBuilder {
982982
trackParCov.getSnp(), trackParCov.getTgl(), trackParCov.getQ2Pt(), cov.data());
983983
}
984984

985-
// free legs (storeFreeLegs): after the tables are written; a track that passes the leg cuts, has a collision and the TPC (as the
985+
// free legs (fillFreeLegs): after the tables are written; a track that passes the leg cuts, has a collision and the TPC (as the
986986
// finder takes them) and is the leg of no stored photon; TPC-only legs moved to their own collision as in the fit
987987
template <bool isMC, class TBCs, class TCollisions, class TTracks>
988988
void writeFreeLegs(TCollisions const& collisions, TTracks const& tracks, std::set<int64_t> const& skimRejected)
@@ -1009,11 +1009,11 @@ struct PhotonConversionBuilder {
10091009
continue;
10101010
}
10111011
}
1012-
if (storeFreeLegIds) { // tracks are visited in increasing index order: store the difference to the previous free leg of this DF
1012+
if (fillFreeLegIds) { // tracks are visited in increasing index order: store the difference to the previous free leg of this DF
10131013
pcmfreelegids(track.collisionId(), static_cast<int>(track.globalIndex() - lastFreeLegTrack));
10141014
lastFreeLegTrack = track.globalIndex();
10151015
}
1016-
if (!storeFreeLegs) {
1016+
if (!fillFreeLegs) {
10171017
++nFree;
10181018
continue;
10191019
}
@@ -1644,7 +1644,7 @@ struct PhotonConversionBuilder {
16441644

16451645
fillTrackTable<isMC>(pos, kfp_pos_DecayVtx, posdcaXY, posdcaZ); // positive leg first
16461646
fillTrackTable<isMC>(ele, kfp_ele_DecayVtx, eledcaXY, eledcaZ); // negative leg second
1647-
if (storeLegCov) {
1647+
if (fillLegCov) {
16481648
fillLegCovTable(pTrack);
16491649
fillLegCovTable(nTrack);
16501650
}
@@ -2661,7 +2661,7 @@ struct PhotonConversionBuilder {
26612661
fitV0Candidate<isMC, TBCs, TCollisions, TTracks>(collision, tracks.rawIteratorAt(fullv0Id.posId), tracks.rawIteratorAt(fullv0Id.eleId), v0Id, true,
26622662
FitOptions{.nonSVertexer = !recovery.finderUniformFit.value, .relaxAP = mRelaxedKeys.contains(fullv0Id) && !recovery.finderUniformFit.value});
26632663
} // end of fullv0Id loop
2664-
if (storeFreeLegs || storeFreeLegIds) {
2664+
if (fillFreeLegs || fillFreeLegIds) {
26652665
writeFreeLegs<isMC, TBCs, TCollisions, TTracks>(collisions, tracks, skimRejected);
26662666
}
26672667

0 commit comments

Comments
 (0)