Skip to content

Commit 3cd62d0

Browse files
author
NarrowsProjects
committed
chore: add placeholders for the new rawTextFilters
1 parent 12877b4 commit 3cd62d0

File tree

4 files changed

+395
-389
lines changed

4 files changed

+395
-389
lines changed

lib/public/components/Filters/LogsFilter/author/AuthorFilterModel.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,9 @@ export class AuthorFilterModel extends RawTextFilterModel {
5656
* @inheritDoc
5757
*/
5858
reset() {
59-
super.reset();
60-
this.notify();
59+
if (this._value !== '') {
60+
super.reset();
61+
this.notify();
62+
}
6163
}
6264
}

lib/public/components/Filters/LogsFilter/author/authorFilter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export const excludeAnonymousLogAuthorToggle = (authorFilterModel) => switchInpu
4444
* @return {Component} the filter component
4545
*/
4646
export const authorFilter = (authorFilterModel) => h('.flex-row.items-center.g3', [
47-
rawTextFilter(authorFilterModel, { classes: ['w-40'], id: 'authorFilterText', value: authorFilterModel.raw }),
47+
rawTextFilter(authorFilterModel, { classes: ['w-40'], id: 'authorFilterText', value: authorFilterModel.raw, placeholder: 'e.g. John Doe'}),
4848
resetAuthorFilterButton(authorFilterModel),
4949
excludeAnonymousLogAuthorToggle(authorFilterModel),
5050
]);

lib/public/views/Logs/ActiveColumns/logsActiveColumns.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,8 @@ export const logsActiveColumns = {
7676
* @param {FilteringModel} logOverviewModel.filteringModel filtering model
7777
* @return {Component} the filter component
7878
*/
79-
filter: ({ filteringModel }) => rawTextFilter(filteringModel.get('title'), { id: 'titleFilterText', classes: ['w-75 mt1'] }),
79+
filter: ({ filteringModel }) =>
80+
rawTextFilter(filteringModel.get('title'), { id: 'titleFilterText', classes: ['w-75 mt1'], placeholder: 'e.g. Report on runs: ...' }),
8081
balloon: true,
8182
profiles: {
8283
embeded: true,
@@ -100,7 +101,7 @@ export const logsActiveColumns = {
100101
* @return {Component} the filter component
101102
*/
102103
filter: ({ filteringModel }) =>
103-
rawTextFilter(filteringModel.get('content'), { id: 'contentFilterText', classes: ['w-75 mt1'] }),
104+
rawTextFilter(filteringModel.get('content'), { id: 'contentFilterText', classes: ['w-75 mt1'], placeholder: 'e.g. Quality of run 52...' }),
104105
},
105106
author: {
106107
name: 'Author',

0 commit comments

Comments
 (0)